Add test for OpenJdkSelfSignedCertGenerator - #15619
Merged
Merged
Conversation
Motivation: We recently had a problem where we run into issues when we ported some changes to 4.2 that made the OpenJdkSelfSignedCertGenerator not work at all anymore. We should test that it works on the expected JDK versions Modifications: Add unit test Result: Better coverage
Member
Author
|
/cc @violetagg ... I will pull this in, port to 4.1 and then reapply the changes for JDK24. |
Member
Author
|
Related to #15613 |
normanmaurer
added a commit
that referenced
this pull request
Sep 4, 2025
Motivation: We recently had a problem where we run into issues when we ported some changes to 4.2 that made the OpenJdkSelfSignedCertGenerator not work at all anymore. We should test that it works on the expected JDK versions Modifications: Add unit test Result: Better coverage
Member
|
Thanks! |
normanmaurer
added a commit
that referenced
this pull request
Sep 4, 2025
Motivation: We recently had a problem where we run into issues when we ported some changes to 4.2 that made the OpenJdkSelfSignedCertGenerator not work at all anymore. We should test that it works on the expected JDK versions Modifications: Add unit test Result: Better coverage
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We recently had a problem where we run into issues when we ported some changes to 4.2 that made the OpenJdkSelfSignedCertGenerator not work at all anymore. We should test that it works on the expected JDK versions
Modifications:
Add unit test
Result:
Better coverage