IoUring: Explicit set CQSIZE by default and use a much saner default … - #15477
Merged
Merged
Conversation
…value for the submission ring Motivation: As default we used a size of 4096 for the submission ring which these days does not make a lot of sense anymore as you can size the submission queue and completion queue seperately. Generally speaking usually you see much more completions compared to submissions, especially as we enable multishot by default these days. Beside this you should also not batch too much in general before submission as this will affect latency. Because of this we should use a more sane default value for the submission queue which will also ensure we submit fast enough while still get some batching to reduce syscalls. Also we need to size the completion queue big enough to be able to receive enough completioms per batch. Modifications: - Change the default submission queue size to 128 - Change the default completion queue size to 4096 Result: Better defaults
Member
Author
|
/cc @dreamlike-ocean |
chrisvest
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…value for the submission ring
Motivation:
As default we used a size of 4096 for the submission ring which these days does not make a lot of sense anymore as you can size the submission queue and completion queue seperately. Generally speaking usually you see much more completions compared to submissions, especially as we enable multishot by default these days. Beside this you should also not batch too much in general before submission as this will affect latency. Because of this we should use a more sane default value for the submission queue which will also ensure we submit fast enough while still get some batching to reduce syscalls. Also we need to size the completion queue big enough to be able to receive enough completioms per batch.
Modifications:
Result:
Better defaults