fix: enable TraceOn will cause OOM when putting a large object - #2251
Conversation
fix: enable TraceOn will cause OOM when putting a large object
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesHTTP tracing
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The title reads fine as-is; two small wording fixes would make the description accurate: fix: enable TraceOn will cause OOM when putting a large object
fix #1771
before pr:
<img width="1355" height="384" alt="image" src="https://github.com/user-attachments/assets/8043328c-bbec-43a5-b2e3-e244ceaa0fcd" />
we can see max memory is 10GB and CPU is 100%
with this pr:
<img width="553" height="746" alt="image" src="https://github.com/user-attachments/assets/8e7b6cde-3dc9-47b5-8c92-f2e10411092a" />
we can see max memory is 26MB and CPU is 34%
|
allanrogerr
left a comment
There was a problem hiding this comment.
@jiuker Please add the in-package test
|
Took another pass over this against The mechanism holds up end to end. With Two things I checked specifically so this can't bite later:
And the regression test does what it claims — I ran it both ways:
|
fix: enable TraceOn will cause OOM when putting a large object


fix #1771
before pr:
we can see max memory is 10GB and CPU is 100%
with this pr:
we can see max memory is 26MB and CPU is 34%
Summary by CodeRabbit
Summary
Bug Fixes
Tests