- can not be string value #15

Activity

1. ljharb commented on Dec 13, 2022

   

   ljharb

   on Dec 13, 2022

   Member

   More actions

   This line dates back to 7cced88#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R63 - iow, it's always been in minimist (and presumably optimist, its precursor, as well).

   I agree that an argument value of - should be permitted. Want to send a PR with a test case, and perhaps also a fix?
2. Yesterday17 commented on Dec 14, 2022

   

   Yesterday17

   on Dec 14, 2022

   Author

   More actions

   Maybe /^-./ could work?
3. shadowspawn commented on Dec 14, 2022

   

   shadowspawn

   on Dec 14, 2022

   Member

   More actions

   The test is done in two places, for a short option and for a long option, and I think should be the same. The pattern used in the other place is more careful and won't fire for a plain -: /^(-|--)[^-]/

   minimist/index.js

   Line 220 in 5784b17

   && !(/^(-|--)[^-]/).test(args[i + 1])

   👍React with 👍1Reacted by Jordan Harband
4. milanholemans commented on Dec 19, 2022

   

   milanholemans

   on Dec 19, 2022

   More actions

   We are having a similar issue, we are trying to run a command with option --id "-9rMKQooUjZdxgv1qQVZYABEuw".
   After parsing, it looks like:

   {
     "1": true,
     "9": true,
     "i": true,
     "r": true,
     "M": true,
     "K": true,
     "Q": true,
     "o": true,
     "U": true,
     "j": true,
     "Z": true,
     "d": true,
     "x": true,
     "g": true,
     "v": true,
     "q": true,
     "V": true,
     "Y": true,
     "A": true,
     "B": true,
     "E": true,
     "u": true,
     "w": true
   }

   Id should be parsed as string and not as flags.
5. shadowspawn commented on Dec 19, 2022

   

   shadowspawn

   on Dec 19, 2022

   Member

   More actions

   @milanholemans Minimist assumes arguments which start with a dash are an option (or options) and not consumed as an option argument. A fix for single dash won't change this behaviour.

   To get the parsing you expect, use an embedded option value with an = like:

   --id=-9rMKQooUjZdxgv1qQVZYABEuw

   Then a possible dash on the start of the id will not change the parsing.

   👍React with 👍3Reacted by Jordan Harband, Milan Holemans and Fabio Spampinato
6. milanholemans commented on Dec 19, 2022

   

   milanholemans

   on Dec 19, 2022

   More actions

   Minimist assumes arguments which start with a dash are an option (or options) and not consumed as an option argument

   I assumed this was the problem indeed.

   To get the parsing you expect, use an embedded option value with an = like:

   This seems to be working indeed, awesome! Thanks for the fast feedback @shadowspawn!

   ❤️React with ❤️2Reacted by Martin Lingstuyl and John Gee
7. topaz1008 commented on Dec 28, 2022

   

   topaz1008

   on Dec 28, 2022

   Last edited by topaz1008

   More actions

   Hello.

   I also have the same problem, and the suggestions here don't solve it 100%.
   I am using Windows10 and Node.js v18.12.1

   To get the parsing you expect, use an embedded option value with an = like:

   This does not work if the value contains a space. you need both an =, and quotation marks " around the parameter.
   e.g.

   > node test.js --command="-c:v copy"
   { _: [ 'copy' ], command: '-c:v' }
   

   Describe the exact steps which reproduce the problem

   // test.js
   import minimist from 'minimist';
   
   const options = minimist(process.argv.slice(2));
   console.log(options);

   Running the following command gives this output:

   > node test.js --command "-c:v copy"
   { _: [], command: true, c: ':v copy' }
   

   Expected output:

   > node test.js --command "-c:v copy"
   { _: [], command: '-c:v copy' }
   

   When writing out the command using BOTH an = (equals) and quotation marks, it works as expected.
   e.g.

   > node test.js --command="-c:v copy"
   { _: [], command: '-c:v copy' }
   
8. ljharb

   added a commit that references this issue on Feb 9, 2023

   [Fix] Fix long option followed by single dash

   ...

   This issue will close once commit 9ec4d27 is merged into the 'main' branch.

   9ec4d27
9. ljharb

   closed this as completedin 9ec4d27on Feb 9, 2023
10. ljharb

    added a commit that references this issue on Feb 9, 2023

    [Fix] Fix long option followed by single dash (#17)

    ...

    This issue will close once commit 63b8fee is merged into the 'main' branch.

    63b8fee