Repository navigation
docs: change mermaidAPI.setConfig() changeset - #8024
aloisklink merged 1 commit into
Conversation
Technically, under semver, deprecations are supposed to be `minor` version bumps, but considering that this function is currently broken and not doing anything, and has been broken for a while, I think we can make this a `patch` version instead.
|
| Name | Type |
|---|---|
| mermaid | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8024 +/- ##
=======================================
Coverage 64.30% 64.30%
=======================================
Files 670 670
Lines 75072 75072
Branches 11171 11171
=======================================
Hits 48273 48273
Misses 26799 26799
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
1 participant
📑 Summary
Add some more information the the deprecation of
mermaidAPI.setConfig()to explain why it's been deprecated, and to change the changeset level to just apatchchange instead of aminorchange.📏 Design Decisions
Technically, under semver, deprecation are supposed to be
minorversion bumps, but considering that this function is currently broken and not doing anything, and has been broken for a while, I think we can make this apatchversion instead.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.