Repository navigation
fix(google): default tool_behavior to NON_BLOCKING on Gemini 3.8 Live - #7329
Merged
Merged
Conversation
Gemini 3.8 Live declares tools NON_BLOCKING unless the client says otherwise. The plugin sent no `behavior` when `tool_behavior` was unset, so the server ran tools async while `supports_silent_scheduling` still read the unset option and stayed False. A tool result with `reply_required=False` then went out without `scheduling: SILENT`, the model answered it anyway, and the warning fired on every call. Resolve the default in `RealtimeModel.__init__` and store it in `_opts`, so the declaration and the scheduling decision read one value. Models without the tag keep sending no `behavior`, and an explicit `tool_behavior` still wins.
longcw
marked this pull request as ready for review
September 18, 2026 03:27
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Gemini 3.8 Live declares tools
NON_BLOCKINGunless the client sends abehaviorfield, and the plugin sends none whiletool_behavioris unset. The server then runs tools async whilesupports_silent_schedulingreads the unset option and staysFalse, so a result withreply_required=Falsegoes out withoutscheduling: SILENTand the model answers it anyway.Fix:
RealtimeModel.__init__resolvestool_behaviortoNON_BLOCKINGfor 3.8 models and stores it in_opts, so the tool declaration and the scheduling decision read one value. Models without the tag still send nobehavior, and an explicittool_behaviorstill wins.Addresses the first item of #7302.
Context for reviewing and coding agents