Skip to content

fix: drop unused audio forwarding buffer - #7144

Merged
chenghao-mou merged 1 commit into
mainfrom
chenghao/fix/AGT-3447-drop-unused-audio-buffer
Sep 7, 2026
Merged

chenghao-mou merged 1 commit into
mainfrom
chenghao/fix/AGT-3447-drop-unused-audio-buffer

Conversation

@chenghao-mou

Copy link
Copy Markdown
Member

Audio forwarding kept every consumed frame in _AudioOutput.audio, which has no readers. Remove that retention so consumed frames can be released while forwarding results remain alive.

A synthetic 60-second, 48 kHz mono stream now retains 0 PCM bytes in the result, down from 5,760,000. Weak-reference regression tests cover direct forwarding and resampling.

Validation: 50 focused tests and make check pass.

Addresses AGT-3447

Initial prompt and agent context

Model: GPT-6

can you investigate linear AGT-3447

okay, let's open a draft PR drop the buffer (if we don't use it at all)

@chenghao-mou
chenghao-mou marked this pull request as ready for review September 6, 2026 11:23
@chenghao-mou
chenghao-mou requested a review from a team as a code owner September 6, 2026 11:23

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@chenghao-mou
chenghao-mou merged commit 6bf544c into main Sep 7, 2026
26 checks passed
@chenghao-mou
chenghao-mou deleted the chenghao/fix/AGT-3447-drop-unused-audio-buffer branch September 7, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants