Repository navigation
fix: drop unused audio forwarding buffer - #7144
Merged
Merged
Conversation
longcw
approved these changes
Sep 7, 2026
chenghao-mou
deleted the
chenghao/fix/AGT-3447-drop-unused-audio-buffer
branch
September 7, 2026 10:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audio forwarding kept every consumed frame in
_AudioOutput.audio, which has no readers. Remove that retention so consumed frames can be released while forwarding results remain alive.A synthetic 60-second, 48 kHz mono stream now retains 0 PCM bytes in the result, down from 5,760,000. Weak-reference regression tests cover direct forwarding and resampling.
Validation: 50 focused tests and
make checkpass.Addresses AGT-3447
Initial prompt and agent context
Model: GPT-6