Repository navigation
chore: isolate ruff dependencies in ci - #7142
Merged
Merged
Conversation
chenghao-mou
marked this pull request as ready for review
September 5, 2026 23:34
davidzhao
approved these changes
Sep 6, 2026
chenghao-mou
deleted the
chenghao/chore/AGT-3449-ruff-ci-dependencies
branch
September 6, 2026 10:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install only locked Ruff for lint and format checks, retain Ruff in dev installs, and give it a separate cache. Python 3.12 satisfies the workspace requirement.
CI medians from three cache-hit runs per version on
ubuntu-latest:Ruff and both type-check jobs pass.
Addresses AGT-3449
CI measurement evidence
Before:
d8607e6711bf9770bfd7e5476f79ab63e6a451a6. After:1b24fcf4f7a295297d75674b65b39c6cbf1801dd.Job times use GitHub's job start/completion timestamps and exclude queue time. Dependency setup uses log timestamps from the
uv syncstep start to the next step start. Cache sizes are compressed archives reported by setup-uv.All six runs use uv 0.12.10 and Ruff 0.15.22, pass lint and format checks, and report 992 formatted files. Python is 3.12.3 before and 3.12.14 after. These measurements compare the full workflow configurations; runner timing varies.
The first run with the isolated cache had a cache miss and took 11 seconds, with 0.600 seconds for dependency setup. It is excluded from the medians.
Initial prompt and agent context
Model: GPT-6