Repository navigation
Conversation
Collaborator
Author
|
@kulshekhar this can be released as a bug fix version if we need so I target merge to master. |
Pull Request Test Coverage Report for Build 4543
💛 - Coveralls |
kulshekhar
approved these changes
Apr 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Jest config which is passed to transformer doesn’t always contain the correct value of
testRegex, see jestjs/jest#9778. Since we rely on this, we should add a filter to make sure we get out the patterns which areRegExpinstance or typestring.Also we add a fallback to default
testMatchvalue, see https://jestjs.io/docs/en/configuration#testmatch-arraystring in case no patterns valid by the check above.Fix #1552
Test plan
Does this PR introduce a breaking change?
Other information
N.A.