Skip to content

fix missing cleanup, if response socket is no longer writeable (issue 1547) - #1593

Merged
titanism merged 3 commits into
koajs:masterfrom
Azlond:master
Feb 27, 2025
Merged

titanism merged 3 commits into
koajs:masterfrom
Azlond:master

Conversation

@Azlond

@Azlond Azlond commented Sep 28, 2021

Copy link
Copy Markdown
Contributor

Relates to issue #1547, see my comment there

@codecov

codecov Bot commented Sep 28, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #1593 (d7570c8) into master (7d8955b) will not change coverage.
The diff coverage is 100.00%.

❗ Current head d7570c8 differs from pull request most recent head bae657d. Consider uploading reports for the commit bae657d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1593   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files           5        5           
  Lines         507      507           
  Branches      142      142           
=======================================
  Hits          505      505           
  Misses          2        2           
Impacted Files Coverage Δ
lib/application.js 98.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d8955b...bae657d. Read the comment docs.

@miwnwski miwnwski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though would you mind adding a test for this?

@Azlond

Azlond commented Oct 11, 2022

Copy link
Copy Markdown
Contributor Author

I don't really know how to write tests for koa, so not sure if I can be of help with that.

@titanism

Copy link
Copy Markdown
Contributor

v2.16.0 released to npm with the backported fix

https://github.com/koajs/koa/releases/tag/2.16.0
https://www.npmjs.com/package/koa/v/2.16.0

We needed this for our work on @forwardemail (since we use HTTP2 server)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants