Skip to content

Use Galata filebrowser helpers in tests - #19645

Merged
krassowski merged 6 commits into
jupyterlab:mainfrom
Darshan808:fix-galata-helper-usage-lint-issue
Sep 11, 2026
Merged

Use Galata filebrowser helpers in tests#19645
krassowski merged 6 commits into
jupyterlab:mainfrom
Darshan808:fix-galata-helper-usage-lint-issue

Conversation

@Darshan808

@Darshan808 Darshan808 commented Aug 30, 2026

Copy link
Copy Markdown
Member

References

Description

Fixes the 53 jupyter/galata-prefer-filebrowser-helper warnings. Three spots keep the raw double-click with an eslint disable and the reason in the comment.

Code changes

Most of them were "double-click the folder, then double-click the file", which collapses into a single helper call:

    await page.notebook.openByPath('notebooks/Lorenz.ipynb');
    await page.filebrowser.open('narrative/jupyterlab.md');
    await page.filebrowser.openDirectory('notebooks');

User-facing changes

None

Backwards-incompatible changes

None

AI usage

  • YES: Some or all of the content of this PR was generated by AI.
  • YES: The human author has carefully reviewed this PR and run this code (keep this PR "draft" until the answer is YES)
  • AI tools and models used: Claude Opus

@jupyterlab-probot

jupyterlab-probot Bot commented Aug 30, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

View the integration tests report in the browser: UI tests report

@Darshan808 Darshan808 changed the title fix-lint-failures Use Galata filebrowser helpers in tests Aug 30, 2026
@Darshan808
Darshan808 marked this pull request as draft August 31, 2026 08:23
@Darshan808
Darshan808 marked this pull request as ready for review September 9, 2026 09:11
@krassowski

krassowski commented Sep 9, 2026

Copy link
Copy Markdown
Member

Should we set them to error?

krassowski
krassowski reviewed Sep 11, 2026
View reviewed changes
Comment thread eslint.config.mjs Outdated
@krassowski krassowski added this to the 4.6.x milestone Sep 11, 2026
@krassowski
krassowski merged commit 4d07601 into jupyterlab:main Sep 11, 2026
123 of 125 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in CFP '25 tracking Sep 11, 2026
@meeseeksmachine meeseeksmachine mentioned this pull request Sep 11, 2026
Merged
krassowski pushed a commit that referenced this pull request Sep 12, 2026
@meeseeksmachine @Darshan808
Backport PR #19645 on branch 4.6.x (Use Galata filebrowser helpers in…
c710847 
… tests) (#19738)

Backport PR #19645: Use Galata filebrowser helpers in tests

Co-authored-by: Darshan Paudyal <pranishpoudel10@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krassowski krassowski krassowski left review comments

Assignees

@Darshan808 Darshan808

Labels

maintenance tag:Testing

Projects

CFP '25 tracking
Status: Done

Milestone

4.6.x

Development

Successfully merging this pull request may close these issues.

3 participants

@Darshan808 @krassowski @MUFFANUJ