Skip to content

Update Altair snapshot - #19488

Merged
krassowski merged 1 commit into
jupyterlab:mainfrom
jtpio:fix-altair-documentation-snapshot
Aug 18, 2026
Merged

krassowski merged 1 commit into
jupyterlab:mainfrom
jtpio:fix-altair-documentation-snapshot

Conversation

@jtpio

@jtpio jtpio commented Aug 18, 2026

Copy link
Copy Markdown
Member

References

Similar to #19204

This should help fix the failing CI check:

image

Code changes

  • Update the Altair snapshot

User-facing changes

None

Backwards-incompatible changes

None

AI usage

N/A

@jupyterlab-probot

jupyterlab-probot Bot commented Aug 18, 2026 •

Copy link
Copy Markdown

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

View the integration tests report in the browser: UI tests report

@jtpio jtpio added this to the 4.6.x milestone Aug 18, 2026
@jtpio
jtpio marked this pull request as ready for review August 18, 2026 17:49

@krassowski krassowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I suppose it comes down to some runner dependencies?

@krassowski
krassowski merged commit 6ef5a17 into jupyterlab:main Aug 18, 2026
114 of 115 checks passed
@lumberbot-app

lumberbot-app Bot commented Aug 18, 2026

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 4.6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 6ef5a17ad831be80c3e63911b77fa9f8acfcbf50
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #19488: Update Altair snapshot'
  1. Push to a named branch:
git push YOURFORK 4.6.x:auto-backport-of-pr-19488-on-4.6.x
  1. Create a PR against branch 4.6.x, I would have named this PR:

"Backport PR #19488 on branch 4.6.x (Update Altair snapshot)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@jtpio

jtpio commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

This seems to explain why the vega version may change over time: https://github.com/vega/altair/blob/86932854b2ca32b0e01b17f880e0dab938e9d949/altair/utils/html.py#L45

Which seems to be the default route taken here in JupyterLab since there is no dedicated renderer for Vega 6 (yet).

@jtpio
jtpio deleted the fix-altair-documentation-snapshot branch August 18, 2026 19:31
jtpio added a commit that referenced this pull request Aug 19, 2026
## References

Manual backport of #19488

## Code changes

See #19488

## User-facing changes

None

## Backwards-incompatible changes

None

## AI usage

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants