Skip to content

Install playwright browser in jupyterlab.browser_check - #15117

Merged
krassowski merged 2 commits into
jupyterlab:mainfrom
brichet:fix_check_browser
Sep 14, 2023
Merged

Install playwright browser in jupyterlab.browser_check#15117
krassowski merged 2 commits into
jupyterlab:mainfrom
brichet:fix_check_browser

Conversation

@brichet

@brichet brichet commented Sep 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Playwright v1.38.0 does not download the browser at installation anymore.

References

Fix #15116

Code changes

Install chrome browser in jupyter.browser_check

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-probot

jupyterlab-probot Bot commented Sep 14, 2023

Copy link
Copy Markdown

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@brichet brichet changed the title Install playwright browser in jupyterlab.check_browser Install playwright browser in jupyterlab.browser_check Sep 14, 2023
@fcollonval fcollonval modified the milestones: 4.0.x, 3.6.x Sep 14, 2023
krassowski
krassowski approved these changes Sep 14, 2023
View reviewed changes

@krassowski krassowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@krassowski
krassowski merged commit c040532 into jupyterlab:main Sep 14, 2023
@krassowski

krassowski commented Sep 14, 2023

Copy link
Copy Markdown
Member

@meeseeksdev please backport to 4.0.x

@krassowski

krassowski commented Sep 14, 2023

Copy link
Copy Markdown
Member

@meeseeksdev please backport to 3.6.x

@meeseeksmachine meeseeksmachine mentioned this pull request Sep 14, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Sep 14, 2023
@brichet @meeseeksmachine
Backport PR jupyterlab#15117: Install playwright browser in jupyterla…
6aaec1c 
…b.browser_check
@lumberbot-app

lumberbot-app Bot commented Sep 14, 2023

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 c04053206ceb66b14af4dca68f089bea9f09830f
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #15117: Install playwright browser in jupyterlab.browser_check'
  1. Push to a named branch:
git push YOURFORK 3.6.x:auto-backport-of-pr-15117-on-3.6.x
  1. Create a PR against branch 3.6.x, I would have named this PR:

"Backport PR #15117 on branch 3.6.x (Install playwright browser in jupyterlab.browser_check)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

krassowski pushed a commit that referenced this pull request Sep 14, 2023
@meeseeksmachine @brichet
Backport PR #15117: Install playwright browser in jupyterlab.browser_…
f73ea9a 
…check (#15118)

Co-authored-by: Nicolas Brichet <32258950+brichet@users.noreply.github.com>
@brichet
brichet deleted the fix_check_browser branch September 14, 2023 19:06
krassowski pushed a commit to krassowski/jupyterlab that referenced this pull request Sep 14, 2023
@brichet @krassowski
Install playwright browser in jupyterlab.browser_check (jupyterlab#15117
16a69b7 
)

* Install playwright browser in jupyterlab.check_browser

* Install all the browsers

(cherry picked from commit c040532)
@krassowski krassowski mentioned this pull request Sep 14, 2023
Merged
@jtpio jtpio mentioned this pull request Sep 18, 2023
Merged
@consideRatio consideRatio mentioned this pull request Sep 19, 2023
Closed
fcollonval pushed a commit that referenced this pull request Sep 25, 2023
@krassowski @brichet
Backport PR #15117 on branch 3.6.x (Install playwright browser in jup…
7d06b49 
…yterlab.browser_check) (#15122)

* Install playwright browser in jupyterlab.browser_check (#15117)

* Install playwright browser in jupyterlab.check_browser

* Install all the browsers

(cherry picked from commit c040532)

* Pin node for docs job on 3.6.x

---------

Co-authored-by: Nicolas Brichet <32258950+brichet@users.noreply.github.com>
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@krassowski krassowski krassowski approved these changes

Assignees

@brichet brichet

Labels

maintenance

Projects

None yet

Milestone

3.6.x

Development

Successfully merging this pull request may close these issues.

jupyterlab.browser_check fails because browser are not installed

3 participants

@brichet @krassowski @fcollonval