Repository navigation
Fix reported location - #262
Merged
Merged
Conversation
Collaborator
|
The fix is straightforward, but we'll need regression tests. |
thatsmydoing
commented
Oct 3, 2024
thatsmydoing
left a comment
thatsmydoing
left a comment
Contributor
Author
There was a problem hiding this comment.
I've added a test case for it.
| { | ||
| errorCount: mockOptions.errorCount, | ||
| warningCount: 0, | ||
| messages: [ |
Contributor
Author
There was a problem hiding this comment.
The number of entries here should probably match mockOptions.errorCount but for the purposes of testing, this is probably fine? The original test didn't even have messages to begin with.
Member
|
I'm away from a laptop today, but can make a release tomorrow or Monday 👍 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #258