Skip to content

style(MatrixTestResult): Increase column width for duration - #178

Merged
rsandell merged 1 commit into
jenkinsci:masterfrom
univention:master
Oct 16, 2023
Merged

rsandell merged 1 commit into
jenkinsci:masterfrom
univention:master

Conversation

@pmhahn

@pmhahn pmhahn commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

4em is too narrow for texts like 6 hr 17 min to fit into: It is shown on two lines as:

6 hr 17
min

The German translation is even worse, which spans 4 lines:

6
Stunden
17
Minuten

which make the table take up too much space.

Testing done

# jar xf matrix-project.jar hudson/tasks/test/MatrixTestResult/index.jelly
# vi  hudson/tasks/test/MatrixTestResult/index.jelly
# jar uf matrix-project.jar hudson/tasks/test/MatrixTestResult/index.jelly
# restart jenkins

jenkins-old
jenkins-new

### Submitter checklist
- [ ] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

`4em` is too narrow for texts like `6 hr 17 min` to fit into: It is shown on two lines as:
> 6 hr 17
> min

The German translation is even worse, which spans 4 lines:
> 6
> Stunden
> 17
> Minuten

which make the table to take up too much space.
@rsandell rsandell added the ui label Oct 16, 2023
@rsandell
rsandell merged commit 7ebe657 into jenkinsci:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants