Repository navigation
Conversation
When normalizing multiple files, x_[0].unicode_path was always used — pointing to the first file's result entry regardless of which file was being processed. This caused the output path to be set on the wrong CliDetectionResult and the normalized content to be written to a path derived from the first file's name. Use x_[-1] to reference the most recently appended result entry, which corresponds to the current file being processed.
Ousret
requested changes
Mar 6, 2026
Ousret
left a comment
Member
There was a problem hiding this comment.
the fix is incomplete/invalid.
I agree something is missing in the case where we pass many files in the CLI.
This need a more careful investigation and proper solution to not confuse current users.
regards,
Ousret
added a commit
that referenced
this pull request
Mar 15, 2026
supersede #702 Co-authored-by: Kadir Can Ozden <101993364+bysiber@users.noreply.github.com>
Merged
Member
|
Solved in PR #715 regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix incorrect file index when writing normalized output for multiple files.
Problem
When normalizing multiple files with
normalizer --normalize file1.txt file2.txt, the CLI always referencesx_[0](the first result entry) instead of the current file's result:For the second file onward, this:
unicode_pathwith the current file's output pathFix
Use
x_[-1]to reference the most recently appended result, which is always the current file being processed.