You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
How to work around broken dependencies (colors.js) #781
I tried downloading older versions of http-server but the issue persists.
How do I work around this? My pipeline is broken. Please consider locking in specific known-working versioned dependencies in package.json instead of just grabbing the latest which may pull in broken/malicious/woke/protest dependencies.
Ah crap, not this again. At least this time colors isn't as integral to http-server as when ecstatic did this. Give me a little time to catch up this latest drama and I'll accept one of the two PRs for this.
Barring any hiccups, I'll merge and release a fix today. I'll also try to backport the fix to the v13 line because I know there are some unrelated issues with the v14 release for some folks.
Reacted by Nahuel Lucero, Sascha Glover, SerhiiBilonohTR, Andrey Shylo, Georg Kothmeier, roomle-build, Nils P. Ellingsen, Jack Hsu, MoritzKronberger and Michael Große
@thornjad Node 17 and and other Node release with an odd major version number is not recommended in general as these are no LTS releases but short living test branches.
That's why I haven't put it on a high priority, but I'd prefer to support it. They are more than just test branches, while not LTS, it is a proper full release, and provide a view of what the next LTS will contain. But its especially frustrating that it works fine in every local environment I've put it in, but gh-actions fails consistently.
npm has a lot of caching in place to deal with the enormity of the traffic it serves, so it might take a while, maybe even a few hours, to show up for everyone. I've verified it did publish though, so its just a matter of time!
Activity
DanielRuf commentedon Jan 9, 2022
You can use resolutions or patch-package to "fix" this as described at Marak/colors.js#285 (comment).
Remove zalgo spam from `colors`
thornjad commentedon Jan 10, 2022
Ah crap, not this again. At least this time colors isn't as integral to http-server as when ecstatic did this. Give me a little time to catch up this latest drama and I'll accept one of the two PRs for this.
nlucero commentedon Jan 10, 2022
@thornjad Thanks for the fast response. Do we have an ETA on when will a fix be merged?
thornjad commentedon Jan 10, 2022
Barring any hiccups, I'll merge and release a fix today. I'll also try to backport the fix to the v13 line because I know there are some unrelated issues with the v14 release for some folks.
[-]How to work around broken dependencies[/-][+]How to work around broken dependencies (colors.js)[/+]thornjad commentedon Jan 10, 2022
Merged #785, just going to see what the tests do (I know Node 17 has some problems) before tagging a release. I'll backport to v13 later today.
DanielRuf commentedon Jan 10, 2022
@thornjad Node 17 and and other Node release with an odd major version number is not recommended in general as these are no LTS releases but short living test branches.
thornjad commentedon Jan 10, 2022
That's why I haven't put it on a high priority, but I'd prefer to support it. They are more than just test branches, while not LTS, it is a proper full release, and provide a view of what the next LTS will contain. But its especially frustrating that it works fine in every local environment I've put it in, but gh-actions fails consistently.
thornjad commentedon Jan 10, 2022
🎉 Published to npm! Check for versions v14.1.0 or v13.1.0
NicholasBoll commentedon Jan 10, 2022
I see the 14.1.0 Github release, but npm doesn't seem to have it yet :(
thornjad commentedon Jan 10, 2022
npm has a lot of caching in place to deal with the enormity of the traffic it serves, so it might take a while, maybe even a few hours, to show up for everyone. I've verified it did publish though, so its just a matter of time!
NicholasBoll commentedon Jan 10, 2022
I see it now. Thanks. I figured npm was behind with caching. After an hour I got a little worried.