Repository navigation
Fixes --proxy without a protocol throwing an uncaught error - #742
Merged
Merged
Conversation
thornjad
requested changes
Oct 11, 2021
thornjad
requested changes
Oct 11, 2021
Co-authored-by: Jade Michael Thornton <jademichael@jmthornton.net>
Co-authored-by: Jade Michael Thornton <jademichael@jmthornton.net>
Contributor
Author
|
Is there anything else that needs changing? Is the test okay? |
thornjad
approved these changes
Oct 11, 2021
thornjad
left a comment
thornjad
left a comment
Member
There was a problem hiding this comment.
I like it! Just a merge conflict left to resolve, a different PR made an unrelated change in the same spot as you, just need to include both changes
Contributor
Author
|
The test fails with url lowercase but passes when it is uppercase. I'm not sure why that is. |
Contributor
Author
|
I fixed it! The issue was a missing comma after the previous require statement. It should pass the tests now. (It did on my machine) |
thornjad
requested changes
Oct 12, 2021
Co-authored-by: Jade Michael Thornton <jademichael@jmthornton.net>
thornjad
approved these changes
Oct 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue where the --proxy would throw an uncaught error when used without specifying a protocol. The fix is having the server not allow you to use --proxy without specifying a valid protocol.
Fixes #451