fix(cors): append Origin to Vary header on OPTIONS preflight - #5235
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5235 +/- ##
=======================================
Coverage 79.77% 79.77%
=======================================
Files 155 155
Lines 10934 10934
Branches 2292 2292
=======================================
Hits 8723 8723
Misses 2211 2211 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
@spellsaif Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that
Vary: Originis appended rather than set onOPTIONSpreflight requests, preserving any preexistingVaryheaders (such asAccept-Encoding) set by upstream middleware.Problem
In
src/middleware/cors/index.ts, theOPTIONSpreflight handler calledset('Vary', 'Origin'), which executesc.res.headers.set('Vary', 'Origin'). This inadvertently overwrites any preexistingVaryheader values set by earlier middleware (e.g.Vary: Accept-Encoding).In contrast, lines 144 (
c.res.headers.append('Vary', 'Access-Control-Request-Headers')) and 161 (c.header('Vary', 'Origin', { append: true })) already use.append()to preserve existing directives.Solution
Use
c.res.headers.append('Vary', 'Origin')in theOPTIONShandler to align with lines 144 and 161, ensuring allVarydirectives are retained.The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code