Repository navigation
backport: Fix multi rrsig validation 0.26 - #3892
Merged
djc merged 2 commits intoSep 5, 2026
Merged
Conversation
verify_default_rrset() races the RRSIG verifications with select_ok(), but reported a failed signature as Ok(None), which select_ok() takes as a success. The first RRSIG to complete decided the result, so an RRset with a valid second signature could end up Bogus depending on the order of the RRSIGs in the response. This affects zones signed with two algorithms, such as mailbox.org. Return an error for a failed signature instead, so the remaining RRSIGs are tried before giving up.
Since 56abc2e only the RRSIG used for verification gets the RRset's proof, any other RRSIG stays Indeterminate. The summary treated those as not secure, so the server never set the AD bit for zones signed with more than one algorithm.
MartB
requested review from
bluejekyll,
cpu,
divergentdave,
djc and
marcus0x62
as code owners
September 5, 2026 14:14
MartB
changed the title
djc
approved these changes
Sep 5, 2026
djc
enabled auto-merge
September 5, 2026 14:21
dadezzz
pushed a commit
to dadezzz/kube-dns-rs
that referenced
this pull request
Sep 11, 2026
![Renovate [bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [hickory-resolver](https://hickory-dns.org/) ([source](https://github.com/hickory-dns/hickory-dns)) | dependencies | patch | `0.26.2` → `0.26.3` | | [hickory-server](https://hickory-dns.org/) ([source](https://github.com/hickory-dns/hickory-dns)) | dependencies | patch | `0.26.2` → `0.26.3` | --- ### Release Notes <details> <summary>hickory-dns/hickory-dns (hickory-resolver)</summary> ### [`v0.26.3`](https://github.com/hickory-dns/hickory-dns/releases/tag/v0.26.3) [Compare Source](hickory-dns/hickory-dns@v0.26.2...v0.26.3) This release fixes regressions introduced in v0.26.2 related to DNSSEC verification, QUIC servers, HTTP/3 servers, and minimum dependency versions. ##### What's Changed - Fix warnings (release/0.26) by [@​divergentdave](https://github.com/divergentdave) in [#​3877](hickory-dns/hickory-dns#3877) - resolver: use lenient resolv.conf parsing by [@​djc](https://github.com/djc) in [#​3879](hickory-dns/hickory-dns#3879) - backport: Fix multi rrsig validation 0.26 by [@​MartB](https://github.com/MartB) in [#​3892](hickory-dns/hickory-dns#3892) - Bump version to 0.26.3 by [@​djc](https://github.com/djc) in [#​3895](hickory-dns/hickory-dns#3895) - Exclude accepting QUIC connections from timeouts - 0.26 branch by [@​divergentdave](https://github.com/divergentdave) in [#​3906](hickory-dns/hickory-dns#3906) - \[0.26] net: fix insecure ancestor delegation by [@​djc](https://github.com/djc) in [#​3907](hickory-dns/hickory-dns#3907) **Full Changelog**: <hickory-dns/hickory-dns@v0.26.2...v0.26.3> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC43NS4xIiwidXBkYXRlZEluVmVyIjoiNDQuNzUuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See merged main pr #3847 for more infos.