Bugfix/add skipped to test output by quintush · Pull Request #838 · helm-unittest/helm-unittest

quintush · 2026-04-07T19:57:00Z

Add skipped tests to test output formats, including tests.

…lm-unittest/helm-unittest into bugfix/AddSkippedToTestOutput

Copilot

Pull request overview

This PR adds support for reporting skipped tests across the project’s test output formats (JUnit, NUnit, XUnit, Sonar), and updates the formatter test suites accordingly.

Changes:

Include skipped test information in TestJobResult.Stringify() and assertion stringification.
Add skipped handling (counts + reason/message) to XML formatters (JUnit/NUnit/XUnit/Sonar).
Extend formatter unit tests to validate skipped test serialization.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
pkg/unittest/results/test_job_result.go	Adds skipped header to stringified test output.
pkg/unittest/results/assertion_result.go	Updates assertion stringification and introduces skipped-path formatting.
pkg/unittest/formatter/xunit_report_xml.go	Adds skipped test counting and `<reason>` output for XUnit XML.
pkg/unittest/formatter/xunit_report_xml_test.go	Updates XUnit tests to cover skipped cases.
pkg/unittest/formatter/sonar_report_xml.go	Adds `<skipped>` element emission for Sonar XML.
pkg/unittest/formatter/sonar_report_xml_test.go	Updates Sonar tests and adds skipped coverage.
pkg/unittest/formatter/nunit_report_xml.go	Adds skipped counting and `<reason>` output for NUnit XML.
pkg/unittest/formatter/nunit_report_xml_test.go	Updates NUnit tests and adds skipped coverage.
pkg/unittest/formatter/junit_report_xml.go	Adds `<skipped>` message emission for JUnit XML.
pkg/unittest/formatter/junit_report_xml_test.go	Updates JUnit tests and adds skipped coverage.
pkg/unittest/formatter/formatter_test.go	Extends test helpers to create skipped jobs/assertions.

Comments suppressed due to low confidence (1)

pkg/unittest/formatter/nunit_report_xml.go:144

totalSuccess is declared and updated but never read. In Go this causes a compile error (unused variable). Remove it, or reintroduce its use in the generated report if it was meant to drive an attribute/value.

	totalTests := 0
	totalErrors := 0
	totalFailures := 0
	totalSkipped := 0
	totalSuccess := true
	testSuites := []NUnitTestSuite{}

	// convert TestSuiteResults to NUnit test suites
	for _, testSuiteResult := range testSuiteResults {
		totalSuccess = totalSuccess && testSuiteResult.Passed

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-07T20:03:08Z

+			if expected[i].Reason != nil || actual[i].Reason != nil {
+				assert.Equal(expected[i].Reason.Reason, actual[i].Reason.Reason)
+				assert.Equal(expected[i].Result, actual[i].Result)
+			} else {
+				// Verify if both are nil, otherwise it's still a failure.
+				assert.True(expected[i].Reason == nil && actual[i].Reason == nil)
+			}


The Reason comparison uses expected[i].Reason != nil || actual[i].Reason != nil and then dereferences both pointers. If one side is nil, this will panic and mask the assertion failure. Use an && check (both non-nil) and keep the nil-equality assertion in the else branch.

Copilot · 2026-04-07T20:03:08Z

+			if expected[i].Reason != nil || actual[i].Reason != nil {
+				assert.Equal(expected[i].Reason.Message, actual[i].Reason.Message)
+				assert.Equal(expected[i].Result, actual[i].Result)
+			} else {
+				// Verify if both are nil, otherwise it's still a failure.
+				assert.True(expected[i].Reason == nil && actual[i].Reason == nil)
+			}


The Reason comparison uses expected[i].Reason != nil || actual[i].Reason != nil and then dereferences both. If only one is nil, this will panic instead of producing a clear test failure. Use an && check (both non-nil) and otherwise assert both are nil.

…ctions on xml output, including tests.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

pkg/unittest/formatter/nunit_report_xml.go:145

totalSuccess is still computed/updated but no longer used in the generated NUnit XML after the createNUnitTestResults signature change. This makes the control flow misleading and suggests a missing output field; consider removing totalSuccess (and the totalSuccess = totalSuccess && ... line) or wiring it back into the XML if it’s still needed.

	totalSuccess := true
	testSuites := []NUnitTestSuite{}

	// convert TestSuiteResults to NUnit test suites
	for _, testSuiteResult := range testSuiteResults {
		totalSuccess = totalSuccess && testSuiteResult.Passed

		ts := n.createNUnitTestSuite(testSuiteResult)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-25T08:51:38Z

+	return content.String()
+}
+
+// Stringify to xml attribute, replacing the the object to a customized formatted string.


Comment has a duplicated word: "replacing the the object". Please correct it for readability.

Suggested change

// Stringify to xml attribute, replacing the the object to a customized formatted string.

// Stringify to xml attribute, replacing the object to a customized formatted string.

Copilot · 2026-04-25T08:51:38Z

+        uses: github/codeql-action/init@c10b8064de6f491fea524254123dbe5e09572f13 #v4.35.1
        with:


The version comments use #v4.35.1 (missing a space after #), which is inconsistent with other version comments in the workflows that use # vX.Y.Z. Consider normalizing for consistency/readability.

Copilot · 2026-04-25T08:51:39Z


      - name: Upload Trivy scan results to GitHub Security tab
-        uses: github/codeql-action/upload-sarif@5d4e8d1aca955e8d8589aabd499c5cae939e33c7 # v4.31.9
+        uses: github/codeql-action/upload-sarif@c10b8064de6f491fea524254123dbe5e09572f13 #v4.35.1


Version comment is #v4.35.1 (missing a space after #), inconsistent with other workflow version comments (e.g. # v6.0.2). Consider using # v4.35.1 for consistency.

Suggested change

uses: github/codeql-action/upload-sarif@c10b8064de6f491fea524254123dbe5e09572f13 #v4.35.1

uses: github/codeql-action/upload-sarif@c10b8064de6f491fea524254123dbe5e09572f13 # v4.35.1

Copilot · 2026-04-25T08:51:39Z

      # Upload the results to GitHub's code scanning dashboard.
      - name: "Upload to code-scanning"
-        uses: github/codeql-action/upload-sarif@5d4e8d1aca955e8d8589aabd499c5cae939e33c7 # v4.31.9
+        uses: github/codeql-action/upload-sarif@c10b8064de6f491fea524254123dbe5e09572f13 #v4.35.1


Version comment is #v4.35.1 (missing a space after #), inconsistent with other workflow version comments (e.g. # v6.0.2). Consider using # v4.35.1 for consistency.

Suggested change

uses: github/codeql-action/upload-sarif@c10b8064de6f491fea524254123dbe5e09572f13 #v4.35.1

uses: github/codeql-action/upload-sarif@c10b8064de6f491fea524254123dbe5e09572f13 # v4.35.1

sonarqubecloud · 2026-04-25T09:27:51Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

quintush added 3 commits March 12, 2026 15:34

Add skipped to testoutput format, including testvalidation.

25da611

Add skipped to testoutput format, including testvalidation.

3de135a

Merge branch 'bugfix/AddSkippedToTestOutput' of https://github.com/he…

b9a1a06

…lm-unittest/helm-unittest into bugfix/AddSkippedToTestOutput

Copilot AI review requested due to automatic review settings April 7, 2026 19:57

Copilot started reviewing on behalf of quintush April 7, 2026 19:57 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

quintush added 2 commits April 7, 2026 23:49

Update pipeline tasks and improve validation on report tests

178f725

Correction on skipped tests when all assertions are skipped and corre…

291d91f

…ctions on xml output, including tests.

quintush requested a review from Copilot April 25, 2026 08:46

Copilot started reviewing on behalf of quintush April 25, 2026 08:46 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Correct comments and remove code complexity.

4e242bc

quintush merged commit c7c5305 into main Apr 25, 2026
10 checks passed

quintush linked an issue Apr 30, 2026 that may be closed by this pull request

Skipped tests appear as Failed in any output format #783

Closed

quintush deleted the bugfix/AddSkippedToTestOutput branch May 27, 2026 07:54

Navigation Menu

Repository navigation

Bugfix/add skipped to test output - #838

Bugfix/add skipped to test output#838
quintush merged 6 commits into
mainfrom
bugfix/AddSkippedToTestOutput

quintush commented Apr 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Apr 25, 2026

Uh oh!

Uh oh!

Copilot AI Apr 25, 2026

Uh oh!

Copilot AI Apr 25, 2026

Uh oh!

Copilot AI Apr 25, 2026

Uh oh!

sonarqubecloud Bot commented Apr 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	// Stringify to xml attribute, replacing the the object to a customized formatted string.
	// Stringify to xml attribute, replacing the object to a customized formatted string.

		uses: github/codeql-action/init@c10b8064de6f491fea524254123dbe5e09572f13 #v4.35.1
		with:

	uses: github/codeql-action/upload-sarif@c10b8064de6f491fea524254123dbe5e09572f13 #v4.35.1
	uses: github/codeql-action/upload-sarif@c10b8064de6f491fea524254123dbe5e09572f13 # v4.35.1

Conversation

quintush commented Apr 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Apr 25, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants