Skip to content

azurerm_cdn_frontdoor_origin.private_link: add web_secondary and Gateway to target_type accepted values - #29380

Merged
catriona-m merged 2 commits into
hashicorp:mainfrom
ycamargo:main
Apr 24, 2025
Merged

catriona-m merged 2 commits into
hashicorp:mainfrom
ycamargo:main

Conversation

@ycamargo

Copy link
Copy Markdown
Contributor

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Support web_secondary and Gateway as a private link target types. These are used for connecting to Azure Storage Static Web Sites and Azure API Management, respectively.
Also, fixed the documentation to add the supported backend services related to the supported target types. Some of them were already supported on the target type list, but they were not listed as supported services, like Azure Storage (Static Web Sites) and Azure Container Apps (preview), for instance.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

Just a validation change, test not required

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #23113
Similar solution used to close #28115

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Added a couple of supported values to the target_type input validation list: "web_secondary" for Static Web Sites and "Gateway" for APIM
Added a couple of supported values to the list of accepted values for the target_type parameter. Also added some new supported backend services for the direct private endpoint connectivity using Private Link list.

@katbyte katbyte left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐈

@WodansSon WodansSon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ycamargo, thanks for opening this PR, it mostly LGTM, but I did have one question. If you can answer that and the tests pass we should be able to get this one in shortly. 🚀

@WodansSon
WodansSon dismissed their stale review April 23, 2025 04:53

I answered my own question

@catriona-m
catriona-m merged commit aa0e391 into hashicorp:main Apr 24, 2025
@github-actions github-actions Bot added this to the v4.27.0 milestone Apr 24, 2025
catriona-m added a commit that referenced this pull request Apr 24, 2025
jackofallops added a commit that referenced this pull request Apr 25, 2025
* Update CHANGELOG.md #29285, #29294

* Update CHANGELOG.md for #29307

* Update CHANGELOG.md #29283

* Update CHANGELOG.md #29271

* Update CHANGELOG.md #29298

* Update CHANGELOG.md #29278

* Update CHANGELOG.md #29341

* Update CHANGELOG.md #29328

* Update CHANGELOG.md #29292

* Update CHANGELOG.md #29361

* Update CHANGELOG.md #29296

* Update CHANGELOG.md #28239

* Update CHANGELOG.md #28974

* Update CHANGELOG.md #29254

* Update CHANGELOG.md #29333

* Update CHANGELOG.md #29314

* Update CHANGELOG.md #28929

* Update CHANGELOG.md for #29382

* Update for #28676

* Update CHANGELOG.md for #28740

* Update CHANGELOG.md for #28559

* Update CHANGELOG.md #29143

* Update CHANGELOG.md #29329

* Update CHANGELOG.md #29380

* Update CHANGELOG.md #29309

* Update CHANGELOG.md #29317

* prep for release

---------

Co-authored-by: Matthew Frahry <mbfrahry@gmail.com>
Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com>
Co-authored-by: kt <kt@katbyte.me>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: jackofallops <ste@hashicorp.com>
teowa pushed a commit to teowa/terraform-provider-azurerm that referenced this pull request May 8, 2025
…way to target_type accepted values (hashicorp#29380)

* add "web_secondary" and "Gateway" to target_type input validation list

Added a couple of supported values to the target_type input validation list: "web_secondary" for Static Web Sites and "Gateway" for APIM

* Add "web_secondary" and "Gateway" to target_type accepted values list

Added a couple of supported values to the list of accepted values for the target_type parameter. Also added some new supported backend services for the direct private endpoint connectivity using Private Link list.
teowa pushed a commit to teowa/terraform-provider-azurerm that referenced this pull request May 8, 2025
* Update CHANGELOG.md hashicorp#29285, hashicorp#29294

* Update CHANGELOG.md for hashicorp#29307

* Update CHANGELOG.md hashicorp#29283

* Update CHANGELOG.md hashicorp#29271

* Update CHANGELOG.md hashicorp#29298

* Update CHANGELOG.md hashicorp#29278

* Update CHANGELOG.md hashicorp#29341

* Update CHANGELOG.md hashicorp#29328

* Update CHANGELOG.md hashicorp#29292

* Update CHANGELOG.md hashicorp#29361

* Update CHANGELOG.md hashicorp#29296

* Update CHANGELOG.md hashicorp#28239

* Update CHANGELOG.md hashicorp#28974

* Update CHANGELOG.md hashicorp#29254

* Update CHANGELOG.md hashicorp#29333

* Update CHANGELOG.md hashicorp#29314

* Update CHANGELOG.md hashicorp#28929

* Update CHANGELOG.md for hashicorp#29382

* Update for hashicorp#28676

* Update CHANGELOG.md for hashicorp#28740

* Update CHANGELOG.md for hashicorp#28559

* Update CHANGELOG.md hashicorp#29143

* Update CHANGELOG.md hashicorp#29329

* Update CHANGELOG.md hashicorp#29380

* Update CHANGELOG.md hashicorp#29309

* Update CHANGELOG.md hashicorp#29317

* prep for release

---------

Co-authored-by: Matthew Frahry <mbfrahry@gmail.com>
Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com>
Co-authored-by: kt <kt@katbyte.me>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: jackofallops <ste@hashicorp.com>
@github-actions

Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

4 participants