Repository navigation
feat: emit NonFatalError on Windows if PATHEXT not populated - #125
Merged
Merged
Conversation
Xaeroxe
force-pushed
the
add-path-ext-error
branch
4 times, most recently
from
June 14, 2026 05:00
8b24ae3 to
e95d15f
Compare
|
I believe this addresses the need to identify and handle errors caused by a missing Apart from docstrings I couldn't find documentation for the nonfatal handler. It might be helpful to add some standard examples to the docs. Thanks for your work on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #123
If this situation is detected,
whichwill now send aNonFatalError::PathExtNotPopulatedto the user providednonfatal_error_handler. This makes it possible to detect and warn about this situation.