Suppress OSC taskbar reset on plain/piped stdout - #37646
Merged
Merged
Conversation
The shutdown hook that emits ESC]9;4;0 BEL to clear iTerm/ConEmu/ Ghostty/Kitty taskbar progress was registered whenever the host terminal was detected via env vars, ignoring the active console mode and whether stdout was actually a terminal. That leaked the trailing control sequence into piped output and into --console=plain runs. Gate the hook on the configuration that actually renders progress: skip it for ConsoleOutput.Plain, and for ConsoleOutput.Auto when stdout is not a TTY. Rich, Verbose, Colored, and Auto-with-TTY are unchanged, preserving the previous behavior.
eskatos
added
a:bug
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
eskatos
marked this pull request as ready for review
April 23, 2026 05:54
eskatos
requested review from
abstratt and
asodja
and removed request for
a team
April 23, 2026 05:54
jbartok
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shutdown hook that emits ESC]9;4;0 BEL to clear iTerm/ConEmu/ Ghostty/Kitty taskbar progress was registered whenever the host terminal was detected via env vars, ignoring the active console mode and whether stdout was actually a terminal. That leaked the trailing control sequence into piped output and into --console=plain runs.
Gate the hook on the configuration that actually renders progress: skip it for ConsoleOutput.Plain, and for ConsoleOutput.Auto when stdout is not a TTY. Rich, Verbose, Colored, and Auto-with-TTY are unchanged, preserving the previous behavior.
Reviewing cheatsheet
Before merging the PR, comments starting with