fix(daemon): copy ExposedPorts from source config in computeImageConfig - #2356
Merged
Merged
Conversation
wrong map in computeImageConfig
Subserial
approved these changes
Jul 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2356 +/- ##
==========================================
+ Coverage 57.21% 57.25% +0.03%
==========================================
Files 166 166
Lines 11517 11517
==========================================
+ Hits 6590 6594 +4
+ Misses 4146 4143 -3
+ Partials 781 780 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 task
social4hyq
pushed a commit
to social4hyq/homebrew-core
that referenced
this pull request
Sep 20, 2026
crane 0.21.8 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre>The artifacts attached to this release are missing SLSA provenance, see #2390. ## What's Changed * build(deps): bump the go-deps group across 1 directory with 3 updates by @dependabot[bot] in google/go-containerregistry#2353 * build(deps): bump golang.org/x/crypto from 0.45.0 to 0.52.0 in /cmd/krane by @dependabot[bot] in google/go-containerregistry#2367 * build(deps): bump golang.org/x/crypto from 0.50.0 to 0.52.0 in /pkg/authn/k8schain by @dependabot[bot] in google/go-containerregistry#2368 * build(deps): bump golang.org/x/net from 0.49.0 to 0.55.0 in /pkg/authn/kubernetes by @dependabot[bot] in google/go-containerregistry#2363 * build(deps): bump the go-deps group across 3 directories with 7 updates by @dependabot[bot] in google/go-containerregistry#2377 * build(deps): bump the actions group across 1 directory with 5 updates by @dependabot[bot] in google/go-containerregistry#2375 * Reject unsafe Windows archive paths in Extract by @Haihan-Jiang in google/go-containerregistry#2330 * feat(goreleaser): add loong64 build support for crane/gcrane/krane by @xuxiaowei-com-cn in google/go-containerregistry#2358 * Document tag and digest reference semantics by @Haihan-Jiang in google/go-containerregistry#2325 * remote: release pull limiter slot when body is read to EOF by @knQzx in google/go-containerregistry#2373 * tarball: bounds-check layer index in uncompressed LayerByDiffID by @arpitjain099 in google/go-containerregistry#2370 * authn: read Podman auth from XDG config by @vigneshakaviki in google/go-containerregistry#2379 * transport: per-host bearer token exchange on cross-host redirect by @amitzig in google/go-containerregistry#2360 * mutate: bounds-check layer index when building rebase addendums by @arpitjain099 in google/go-containerregistry#2371 * fix(daemon): copy ExposedPorts from source config in computeImageConfig by @x64vps in google/go-containerregistry#2356 * feat(remote): add WithReferrersTagFallback option by @kevinmdavis in google/go-containerregistry#2366 * mutate: apply opaque-directory whiteouts (.wh..wh..opq) in Extract by @sadmanf in google/go-containerregistry#2372 * tarball: use correct file extension for zstd/uncompressed by @milas in google/go-containerregistry#2382 * build(deps): bump github.com/moby/moby/client from 0.5.0 to 0.5.1 in the go-deps group across 1 directory by @dependabot[bot] in google/go-containerregistry#2380 * actions: update actions to be pinned by hash by @Subserial in google/go-containerregistry#2384 * Bump go version to 1.26.5 by @Subserial in google/go-containerregistry#2388 ## New Contributors * @xuxiaowei-com-cn made their first contribution in google/go-containerregistry#2358 * @knQzx made their first contribution in google/go-containerregistry#2373 * @arpitjain099 made their first contribution in google/go-containerregistry#2370 * @vigneshakaviki made their first contribution in google/go-containerregistry#2379 * @amitzig made their first contribution in google/go-containerregistry#2360 * @x64vps made their first contribution in google/go-containerregistry#2356 * @kevinmdavis made their first contribution in google/go-containerregistry#2366 * @sadmanf made their first contribution in google/go-containerregistry#2372 **Full Changelog**: https://github.com/google/go-containerregistry/compare/v0.21.7...v0.21.8</pre> <p>View the full release notes at <a href="https://github.com/google/go-containerregistry/releases/tag/v0.21.8">https://github.com/google/go-containerregistry/releases/tag/v0.21.8</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!15552
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
computeImageConfigranged over the freshly-emptied destination mapinstead of the source config, so
ExposedPortswas always dropped fromdaemon-loaded images. Fixed the loop and added a test.