Skip to content

refactor: merge space-before-blocks - #698

Merged
antfu merged 1 commit into
eslint-stylistic:mainfrom
9romise:refactor/space-before-blocks
Feb 26, 2025
Merged

antfu merged 1 commit into
eslint-stylistic:mainfrom
9romise:refactor/space-before-blocks

Conversation

@9romise

@9romise 9romise commented Feb 21, 2025

Copy link
Copy Markdown
Member

Description

Linked Issues

Part of #482

Additional context


return {
...rules,
TSEnumDeclaration: checkSpaceAfterEnum,

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check TSEnumBody directly.

requireSpace = alwaysFunctions
requireNoSpace = neverFunctions
}
else if (node.type === 'ClassBody' || node.type === 'TSEnumBody' || node.type === 'TSInterfaceBody') {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff with js version:
add

node.type === 'TSEnumBody' || node.type === 'TSInterfaceBody'

@codecov

codecov Bot commented Feb 21, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (e6dbb9d) to head (7909f54).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
- Coverage   95.72%   95.05%   -0.67%     
==========================================
  Files         122      122              
  Lines       20377    20452      +75     
  Branches     4814     4805       -9     
==========================================
- Hits        19506    19441      -65     
- Misses        871     1011     +140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antfu
antfu added this pull request to the merge queue Feb 26, 2025
Merged via the queue into eslint-stylistic:main with commit 6e8554d Feb 26, 2025
@9romise
9romise deleted the refactor/space-before-blocks branch March 3, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants