Skip to content

refactor(line-comment-position): simplify options initialization - #1106

Merged
9romise merged 4 commits into
eslint-stylistic:mainfrom
9romise:line-comment-position/options
Jan 18, 2026
Merged

refactor(line-comment-position): simplify options initialization#1106
9romise merged 4 commits into
eslint-stylistic:mainfrom
9romise:line-comment-position/options

Conversation

@9romise

@9romise 9romise commented Jan 17, 2026

Copy link
Copy Markdown
Member

Before submitting the PR, please make sure you do the following:

  • Read the Contributing Guide.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
  • If this PR changes documented rule default options, I've confirmed it is not addressing the intentional difference between rule defaults and preset values described in #890.

Description

Linked Issues

Additional context

@pkg-pr-new

pkg-pr-new Bot commented Jan 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@stylistic/eslint-plugin@1106

npm i https://pkg.pr.new/@eslint-stylistic/metadata@1106

commit: 6962b1c

@codecov

codecov Bot commented Jan 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.78%. Comparing base (a49451f) to head (6962b1c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1106      +/-   ##
==========================================
- Coverage   98.78%   98.78%   -0.01%     
==========================================
  Files          96       96              
  Lines        8805     8801       -4     
  Branches     3295     3295              
==========================================
- Hits         8698     8694       -4     
  Misses        103      103              
  Partials        4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

9romise and others added 3 commits January 18, 2026 11:09
@9romise
Merge branch 'main' into line-comment-position/options
5f510cd 
# Conflicts:
#	packages/eslint-plugin/rules/line-comment-position/line-comment-position.ts
@autofix-ci
[autofix.ci] apply automated fixes
96c2dda
@9romise
cleanup
6962b1c
@9romise
9romise enabled auto-merge January 18, 2026 03:13
@9romise
9romise added this pull request to the merge queue Jan 18, 2026
Merged via the queue into eslint-stylistic:main with commit 4d6b10a Jan 18, 2026
14 checks passed
@9romise
9romise deleted the line-comment-position/options branch January 18, 2026 03:20
@antfu antfu mentioned this pull request Jan 18, 2026
Merged
@codecov

codecov Bot commented Jan 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 234 bytes (-0.04%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@stylistic/eslint-plugin-esm 618.57kB -234 bytes (-0.04%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: @stylistic/eslint-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
rules/line-comment-position.js -234 bytes 2.17kB -9.72%

Files in rules/line-comment-position.js:

  • ./rules/line-comment-position/line-comment-position.ts → Total Size: 2.08kB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@9romise