Skip to content

fix(disable-legacy): disable multiline-comment-style - #1103

Merged
9romise merged 1 commit into
eslint-stylistic:mainfrom
9romise:fix/disable-legacy
Jan 17, 2026
Merged

fix(disable-legacy): disable multiline-comment-style#1103
9romise merged 1 commit into
eslint-stylistic:mainfrom
9romise:fix/disable-legacy

Conversation

@9romise

@9romise 9romise commented Jan 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Before submitting the PR, please make sure you do the following:

  • Read the Contributing Guide.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
  • If this PR changes documented rule default options, I've confirmed it is not addressing the intentional difference between rule defaults and preset values described in #890.

Description

Linked Issues

fixes #396

Additional context

https://eslint.org/docs/latest/rules/multiline-comment-style

@pkg-pr-new

pkg-pr-new Bot commented Jan 17, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@stylistic/eslint-plugin@1103

npm i https://pkg.pr.new/@eslint-stylistic/metadata@1103

commit: 8333a07

@codecov

codecov Bot commented Jan 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.76%. Comparing base (60aafcb) to head (8333a07).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1103   +/-   ##
=======================================
  Coverage   98.76%   98.76%           
=======================================
  Files          96       96           
  Lines        8857     8857           
  Branches     3320     3316    -4     
=======================================
  Hits         8748     8748           
  Misses        105      105           
  Partials        4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@9romise
9romise added this pull request to the merge queue Jan 17, 2026
Merged via the queue into eslint-stylistic:main with commit 03fc476 Jan 17, 2026
14 checks passed
@9romise
9romise deleted the fix/disable-legacy branch January 17, 2026 08:35
@antfu antfu mentioned this pull request Jan 17, 2026
Merged
@codecov

codecov Bot commented Jan 17, 2026

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 31 bytes (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@stylistic/eslint-plugin-esm 619.64kB 31 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: @stylistic/eslint-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
configs.js 31 bytes 23.94kB 0.13%

Files in configs.js:

  • ./configs/disable-legacy.ts → Total Size: 3.37kB

@chrisbbreuer chrisbbreuer mentioned this pull request Jan 23, 2026
Closed
1 task
This was referenced Feb 5, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@stylistic/multiline-comment-style: shouldn't the eslint rule be turned off in @stylistic/disable-legacy?

1 participant

@9romise