fix: don't report `__proto__` properties in `object-shorthand` by xbinaryx · Pull Request #21310 · eslint/eslint

xbinaryx · 2026-09-07T19:34:50Z

Prerequisites checklist

I have read the contributing guidelines.

AI acknowledgment

I did not use AI to generate this PR.
(If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What parser are you using (place an "X" next to just one item)?

[x] Default (Espree)
[ ] @typescript-eslint/parser
[ ] @babel/eslint-parser
[ ] vue-eslint-parser
[ ] @angular-eslint/template-parser
[ ] Other

Please show your full configuration:

Configuration

export default [{
  rules: {
    "object-shorthand": "error"
   }
}];

What did you do? Please include the actual source code causing the issue.

const a = { __proto__: function () {} };
const b = { __proto__: __proto__ };

What did you expect to happen?

No errors. A non-computed __proto__ key in an object literal is a prototype setter, not an ordinary property, so there is no shorthand form that preserves its meaning.

What actually happened? Please include the actual, raw output from ESLint.

Both are reported and autofixed into code that behaves differently.

What changes did you make? (Give an overview)

Property:exit returns early for such properties.
isRedundant() returns false for them.

Is there anything you'd like reviewers to focus on?

Summary by CodeRabbit

Bug Fixes
- Updated object-shorthand validation to correctly handle non-computed __proto__ properties.
- These properties are no longer incorrectly reported as redundant or automatically converted to shorthand syntax.
- Computed, quoted, shorthand, and method forms continue to be evaluated according to the configured rule options.
Tests
- Added coverage for __proto__ properties and methods across supported configurations, including valid cases, reported errors, and autofixes.

netlify · 2026-09-07T19:34:56Z

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	`731859b`
🔍 Latest deploy log	https://app.netlify.com/projects/docs-eslint/deploys/6a9f207be90dd300084342ae

coderabbitai · 2026-09-07T19:35:38Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 1052f208-dabe-4054-bc4a-09f202bab170

📥 Commits

Reviewing files that changed from the base of the PR and between 4a4147d and 731859b.

📒 Files selected for processing (1)

lib/rules/object-shorthand.js

🚧 Files skipped from review as they are similar to previous changes (1)

lib/rules/object-shorthand.js

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The object-shorthand rule now identifies non-computed __proto__ properties and excludes them from redundancy checks, shorthand validation, and autofixing. Tests cover valid and invalid cases across supported configuration modes.

Changes

Object shorthand __proto__ handling

Layer / File(s)	Summary
Exclude `__proto__` from shorthand enforcement `lib/rules/object-shorthand.js`	The rule detects non-computed `__proto__` properties, treats them as non-redundant, and skips shorthand validation and autofixing.
Validate `__proto__` behavior `tests/lib/rules/object-shorthand.js`	Tests cover quoted, computed, shorthand, longform, method, and consistency cases across rule configurations.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 73185

The rule excludes non-computed proto prototype setters from shorthand enforcement and autofixing, with no outstanding merge-readiness risk identified.

Suggested reviewers: dmartens

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: preventing `object-shorthand` from reporting `__proto__` properties.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

DMartens

Thank you for the PR.
I am able to reproduce this behavior and agree that __proto__ should be exempted.

DMartens

Changes LGTM, thanks. Leaving open for others to review.

mdjermanovic

LGTM, thanks!

| datasource | package | from | to | | ---------- | ------- | ------ | ------- | | npm | eslint | 10.9.1 | 10.11.0 | ## [v10.11.0](https://github.com/eslint/eslint/releases/tag/v10.11.0) #### Features - [`d136fa4`](eslint/eslint@d136fa4) feat: object-shorthand handle quoted properties for `ignoreConstructors` ([#21271](eslint/eslint#21271)) (Pavel) - [`397b3b8`](eslint/eslint@397b3b8) feat: report unsafe labeled `continue` in `no-unsafe-finally` rule ([#21316](eslint/eslint#21316)) (electrohyun) - [`d3dd47f`](eslint/eslint@d3dd47f) feat: only exempt `new-cap` built-ins that reference the global ([#21290](eslint/eslint#21290)) (sethamus) #### Bug Fixes - [`22b09f5`](eslint/eslint@22b09f5) fix: ignore `__proto__` properties in `prefer-object-spread` ([#21311](eslint/eslint#21311)) (xbinaryx) - [`b684bb1`](eslint/eslint@b684bb1) fix: make TimePass.parse optional in types and docs ([#21313](eslint/eslint#21313)) (ntnyq) - [`26d11bc`](eslint/eslint@26d11bc) fix: don't report `__proto__` properties in `object-shorthand` ([#21310](eslint/eslint#21310)) (xbinaryx) #### Documentation - [`9ecfdc5`](eslint/eslint@9ecfdc5) docs: note that --cache can serve stale results for cross-file rules ([#21312](eslint/eslint#21312)) (bytedoe) - [`6c789ff`](eslint/eslint@6c789ff) docs: Update README (GitHub Actions Bot) - [`5997825`](eslint/eslint@5997825) docs: clarify preserve-caught-error known limitation ([#21294](eslint/eslint#21294)) (Akinyemi Toluwalase) #### Chores - [`520dd77`](eslint/eslint@520dd77) perf: Implement fast paths in critical areas ([#21210](eslint/eslint#21210)) (Nicholas C. Zakas) - [`92086c8`](eslint/eslint@92086c8) test: update `EMFILE` error generation for Node.js 26.9.0 compatibility ([#21330](eslint/eslint#21330)) (Francesco Trotta) - [`9ac7eb6`](eslint/eslint@9ac7eb6) chore: update github/codeql-action action to v4.38.0 ([#21331](eslint/eslint#21331)) (renovate\[bot]) - [`24310e3`](eslint/eslint@24310e3) chore: update ecosystem plugins ([#21324](eslint/eslint#21324)) (ESLint Bot) - [`45ad79e`](eslint/eslint@45ad79e) ci: bump pnpm/action-setup from 6.0.10 to 6.1.0 ([#21318](eslint/eslint#21318)) (dependabot\[bot]) - [`ac74e37`](eslint/eslint@ac74e37) chore: Add AGENTS.md with AI disclosure requirements ([#21221](eslint/eslint#21221)) (Nicholas C. Zakas) - [`c832660`](eslint/eslint@c832660) chore: Upgrade Stylelint to the latest version in docs ([#21245](eslint/eslint#21245)) (Jung Hyeon Jun) - [`f9f88fc`](eslint/eslint@f9f88fc) chore: update ecosystem plugins ([#21308](eslint/eslint#21308)) (ESLint Bot) - [`fc81076`](eslint/eslint@fc81076) ci: add more types integration tests ([#20395](eslint/eslint#20395)) (Nitin Kumar) ## [v10.10.0](https://github.com/eslint/eslint/releases/tag/v10.10.0) #### Features - [`264b434`](eslint/eslint@264b434) feat: add `d` and `v` flags to `no-unexpected-multiline` ([#21305](eslint/eslint#21305)) (Gihyeon Jeong / 정기현) - [`c6cc6c5`](eslint/eslint@c6cc6c5) feat: check `Object.prototype` property names in `new-cap` ([#21269](eslint/eslint#21269)) (crimsonjay0) - [`5661fa6`](eslint/eslint@5661fa6) feat: no-extra-bind false negatives with class fields and static blocks ([#21260](eslint/eslint#21260)) (synthex-byte) #### Bug Fixes - [`bb47dc6`](eslint/eslint@bb47dc6) fix: update dependency file-entry-cache to v11 ([#20801](eslint/eslint#20801)) (Milos Djermanovic) - [`427ac0a`](eslint/eslint@427ac0a) fix: use format strings in debug calls ([#21247](eslint/eslint#21247)) (Francesco Trotta) - [`9d81532`](eslint/eslint@9d81532) fix: support `__proto__` in `/* exported */` comments ([#21261](eslint/eslint#21261)) (sethamus) - [`87e0a08`](eslint/eslint@87e0a08) fix: prefer-object-has-own autofix breaks when Object is shadowed ([#21282](eslint/eslint#21282)) (김채영) - [`8e2cb14`](eslint/eslint@8e2cb14) fix: `new-cap` false positive for `UTC` calls with `properties: false` ([#21275](eslint/eslint#21275)) (Pixel) - [`9f4a364`](eslint/eslint@9f4a364) fix: Ignore static imports in no-unreachable ([#21276](eslint/eslint#21276)) (Taha Kotil) #### Documentation - [`2417cad`](eslint/eslint@2417cad) docs: Update README (GitHub Actions Bot) - [`9cecb8a`](eslint/eslint@9cecb8a) docs: document `\c` control letter escapes in no-control-regex ([#21286](eslint/eslint#21286)) (한국) - [`8724829`](eslint/eslint@8724829) docs: update compat table links ([#21263](eslint/eslint#21263)) (fnx) - [`5634542`](eslint/eslint@5634542) docs: Clarify eqeqeq suggestion behavior ([#21256](eslint/eslint#21256)) (Müslüm Yılmaz) #### Chores - [`b3d876b`](eslint/eslint@b3d876b) chore: disable npm audit in ecosystem tests ([#21306](eslint/eslint#21306)) (Francesco Trotta) - [`1696682`](eslint/eslint@1696682) ci: restore EMFILE test on Node.js 26 ([#21297](eslint/eslint#21297)) (Marry (Subin Yang)) - [`2c7f5d6`](eslint/eslint@2c7f5d6) chore: update github/codeql-action action to v4.37.9 ([#21296](eslint/eslint#21296)) (renovate\[bot]) - [`3c753f1`](eslint/eslint@3c753f1) chore: update eslint ([#21289](eslint/eslint#21289)) (renovate\[bot]) - [`1c73469`](eslint/eslint@1c73469) chore: update ecosystem plugins ([#21280](eslint/eslint#21280)) (ESLint Bot) - [`08a02be`](eslint/eslint@08a02be) test: add error locations to `no-extra-boolean-cast` ([#21266](eslint/eslint#21266)) (lumir) - [`77bb1db`](eslint/eslint@77bb1db) chore: update github/codeql-action action to v4.37.8 ([#21270](eslint/eslint#21270)) (renovate\[bot]) - [`007e81a`](eslint/eslint@007e81a) ci: skip EMFILE test on Node.js 26 ([#21265](eslint/eslint#21265)) (lumir) - [`0430280`](eslint/eslint@0430280) chore: improve ecosystem tests compatibility on Windows ([#21178](eslint/eslint#21178)) (crimsonjay0)

fix: don't report __proto__ properties in object-shorthand

4a4147d

xbinaryx requested a review from a team as a code owner September 7, 2026 19:34

github-project-automation Bot added this to Triage Sep 7, 2026

eslint-github-bot Bot added the bug ESLint is working incorrectly label Sep 7, 2026

github-project-automation Bot moved this to Needs Triage in Triage Sep 7, 2026

github-actions Bot added the rule Relates to ESLint's core rules label Sep 7, 2026

DMartens requested changes Sep 7, 2026

View reviewed changes

Comment thread lib/rules/object-shorthand.js

DMartens moved this from Needs Triage to Implementing in Triage Sep 7, 2026

DMartens added the accepted There is consensus among the team that this change meets the criteria for inclusion label Sep 7, 2026

explain __proto__ semantics in the isProtoKey JSDoc

731859b

DMartens moved this from Implementing to Merge Candidates in Triage Sep 8, 2026

DMartens approved these changes Sep 8, 2026

View reviewed changes

mdjermanovic approved these changes Sep 9, 2026

View reviewed changes

mdjermanovic merged commit 26d11bc into eslint:main Sep 9, 2026
46 checks passed

github-project-automation Bot moved this from Merge Candidates to Complete in Triage Sep 9, 2026

mtrezza mentioned this pull request Sep 26, 2026

refactor: Bump eslint from 10.7.0 to 10.11.0 parse-community/parse-server-push-adapter#614

Merged

github-actions Bot mentioned this pull request Oct 2, 2026

chore(deps): update dependency eslint to v10.11.0 victoraugustoas/finance-manager#150

Merged

1 task

Navigation Menu

Repository navigation

fix: don't report `proto` properties in `object-shorthand` - #21310

fix: don't report `proto` properties in `object-shorthand`#21310
mdjermanovic merged 2 commits into
eslint:mainfrom
xbinaryx:object-shorthand-proto

xbinaryx commented Sep 7, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

netlify Bot commented Sep 7, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 7, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

DMartens left a comment

Uh oh!

Uh oh!

DMartens left a comment

Uh oh!

mdjermanovic left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

xbinaryx commented Sep 7, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Prerequisites checklist

AI acknowledgment

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Summary by CodeRabbit

Uh oh!

netlify Bot commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for docs-eslint canceled.

Uh oh!

coderabbitai Bot commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

DMartens left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DMartens left a comment

Choose a reason for hiding this comment

Uh oh!

mdjermanovic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xbinaryx commented Sep 7, 2026 •

edited by coderabbitai Bot

Loading

netlify Bot commented Sep 7, 2026 •

edited

Loading

coderabbitai Bot commented Sep 7, 2026 •

edited

Loading