Repository navigation
test: add unit tests for SuppressionsService.applySuppressions() - #20863
Merged
mdjermanovic merged 1 commit intoMay 12, 2026
Merged
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Add unit tests for
SuppressionsService.applySuppressions().What changes did you make? (Give an overview)
This is the final follow-up to #20734 (
load()), #20765 (suppress()), #20797 (prune()), and #20802 (save()), completing the full unit test coverage ofSuppressionsService.This PR adds unit tests for the
applySuppressions()method inlib/services/suppressions-service.js:violationsCount <= suppressionsCountvs>violationsCount < suppressionsCountand unmatched rulesunusedreturn value correctly reflects the difference and fully unmatched suppressions!suppressions[relativeFilePath]→continuestructuredClone(results)resultsarray is not modified by the methodSince
applySuppressions()is a pure synchronous method, tests call it directly with crafted inputs without needingsinonstubs.With this PR, all public methods of
SuppressionsServicenow have dedicated test coverage:load()suppress()prune()save()applySuppressions()The remaining helper methods (
countViolationsByRule,suppressMessagesByRule,getRelativeFilePath) are all exercised indirectly through the tests above.Is there anything you'd like reviewers to focus on?
The tests cover all branches in the method, including the early
continuefor unmatched files, the suppress-vs-report threshold, and thestructuredClonenon-mutation guarantee.