Skip to content

ci: add Node.js 26 to CI - #20847

Merged
fasttime merged 7 commits into
mainfrom
ci/add-nodejs26-to-ci
Jun 27, 2026
Merged

fasttime merged 7 commits into
mainfrom
ci/add-nodejs26-to-ci

Conversation

@lumirlumir

@lumirlumir lumirlumir commented May 7, 2026 •

Copy link
Copy Markdown
Member

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

On May 5, 2026, Node.js 26 was released.

Ref: https://github.com/nodejs/node/releases/tag/v26.0.0

This PR is a straightforward CI matrix update to run tests on Node.js 26.

Just as dropping Node.js 25 from CI was suggested in eslint/eslintrc#231 (comment), I’ve removed it as well.

Related Issue: #20848

Is there anything you'd like reviewers to focus on?

I think c8’s yargs was not a blocker here. Even without overriding yargs, it worked as expected, so I only updated the CI matrix.

@lumirlumir
lumirlumir requested a review from a team as a code owner May 7, 2026 09:29
@eslint-github-bot eslint-github-bot Bot added the build This change relates to ESLint's build process label May 7, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage May 7, 2026
@netlify

netlify Bot commented May 7, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 17ae696
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/6a3e7bbc3818160008654d90

@lumirlumir
lumirlumir marked this pull request as draft May 7, 2026 09:34
@lumirlumir lumirlumir moved this from Needs Triage to Implementing in Triage May 7, 2026
@lumirlumir lumirlumir closed this May 7, 2026
@github-project-automation github-project-automation Bot moved this from Implementing to Complete in Triage May 7, 2026
@lumirlumir

Copy link
Copy Markdown
Member Author

It appears there's a regression in Node.js 26, so I'm using this tracker instead: #20848

@jnoordsij jnoordsij mentioned this pull request May 28, 2026
2 of 3 tasks
@lumirlumir

Copy link
Copy Markdown
Member Author

Reopening this, as there’s consensus in #20848.

@lumirlumir lumirlumir reopened this Jun 26, 2026
@github-project-automation github-project-automation Bot moved this from Complete to Evaluating in Triage Jun 26, 2026
@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 26, 2026
@lumirlumir lumirlumir moved this from Evaluating to Implementing in Triage Jun 26, 2026
@lumirlumir
lumirlumir marked this pull request as ready for review June 26, 2026 13:22
@lumirlumir lumirlumir moved this from Implementing to Needs Triage in Triage Jun 26, 2026
@fasttime

Copy link
Copy Markdown
Member

I think c8’s yargs was not a blocker here. Even without overriding yargs, it worked as expected, so I only updated the CI matrix.

A patch release for Yargs 17, yargs@17.7.3 was released a few days ago to fix the incompatibility with Node.js 26.

@fasttime fasttime moved this from Needs Triage to Implementing in Triage Jun 26, 2026

@fasttime fasttime left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime
fasttime merged commit 7c9a029 into main Jun 27, 2026
41 of 42 checks passed
@fasttime
fasttime deleted the ci/add-nodejs26-to-ci branch June 27, 2026 09:42
@github-project-automation github-project-automation Bot moved this from Implementing to Complete in Triage Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion build This change relates to ESLint's build process github actions

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants