Repository navigation
chore: fix internal type references to Plugin and Rule - #19665
Merged
Merged
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
github-actions
Bot
added
rule
fasttime
commented
Apr 28, 2025
| * rules.get("semi"); // call `() => require("semi")` here. | ||
| * | ||
| * @extends {Map<string, () => Rule>} | ||
| * @extends {Map<string, Rule>} |
Member
Author
There was a problem hiding this comment.
This was an oversight in the current JSDoc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:
Fix internal types
What changes did you make? (Give an overview)
I noticed that the
Plugintype defined inlib/shared/typeswas out of date, so I removed it and replaced its references withESLint.Pluginfrom the TypeScript types inlib/types.I also replaced references to the previously removed
Ruletype inlib/shared/types.jswithRule.RuleModulefromlib/types.Is there anything you'd like reviewers to focus on?