Repository navigation
docs: add types for multiple rule options - #19616
Merged
Merged
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
snitin315
reviewed
Apr 11, 2025
snitin315
changed the title
snitin315
added
accepted
mdjermanovic
approved these changes
Apr 11, 2025
mdjermanovic
left a comment
mdjermanovic
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks! Leaving open for @snitin315 to verify.
snitin315
approved these changes
Apr 17, 2025
snitin315
left a comment
snitin315
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks! Apologies for the delay in re-review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
What changes did you make? (Give an overview)
Added the types to new options that are added to support TypeScript syntax.
Is there anything you'd like reviewers to focus on?
No