Skip to content

fix: do not exit process on rule crash - #19436

Merged
mdjermanovic merged 2 commits into
mainfrom
issue19243
Feb 20, 2025
Merged

mdjermanovic merged 2 commits into
mainfrom
issue19243

Conversation

@fasttime

@fasttime fasttime commented Feb 19, 2025 •

Copy link
Copy Markdown
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

fixes #19243

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot Bot added the chore This change is not user-facing label Feb 19, 2025
@netlify

netlify Bot commented Feb 19, 2025 •

Copy link
Copy Markdown

✅ Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit b52c9e0
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67b6be3685ffa800089cad05
😎 Deploy Preview https://deploy-preview-19436--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment thread package.json Outdated
@fasttime fasttime changed the title test: rule crash should not exit process fix: do not exit process on rule crash Feb 20, 2025
@eslint-github-bot eslint-github-bot Bot added the bug ESLint is working incorrectly label Feb 20, 2025
@fasttime fasttime added accepted There is consensus among the team that this change meets the criteria for inclusion dependencies Pull requests that update a dependency file and removed chore This change is not user-facing labels Feb 20, 2025
@fasttime
fasttime marked this pull request as ready for review February 20, 2025 05:40
@fasttime
fasttime requested a review from a team as a code owner February 20, 2025 05:40

@mdjermanovic mdjermanovic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic
mdjermanovic merged commit d8ffdd4 into main Feb 20, 2025
@mdjermanovic
mdjermanovic deleted the issue19243 branch February 20, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly dependencies Pull requests that update a dependency file

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Bug: Unexpected process exit on next tick when rule throws error since 9.14

2 participants