Repository navigation
docs: Update Eleventy from v2 to v3 - #19415
Merged
Merged
Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdjermanovic
approved these changes
Feb 10, 2025
mdjermanovic
left a comment
mdjermanovic
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks! I verified that the output in _site is same before and after this change.
Leaving open for a second review.
mdjermanovic
added
the
accepted
nzakas
approved these changes
Feb 10, 2025
nzakas
left a comment
nzakas
left a comment
Member
There was a problem hiding this comment.
LGTM. Will leave open until after the patch release.
stars74shy
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Update Eleventy from v2 to v3
What changes did you make? (Give an overview)
Ref: eslint/eslint.org#644
similar to eslint/eslint.org#690
I updated Eleventy from v2 to v3, verified the dev server, and tried building the website. Everything worked fine.
I didn't notice much difference in the build time.
Is there anything you'd like reviewers to focus on?