Skip to content

docs: add missing messageId property and suggestion properties - #19122

Merged
fasttime merged 2 commits into
eslint:mainfrom
DMartens:docs-lint-message-type-missing
Nov 13, 2024
Merged

fasttime merged 2 commits into
eslint:mainfrom
DMartens:docs-lint-message-type-missing

Conversation

@DMartens

Copy link
Copy Markdown
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

  • Add messageId property to LintMessage, SuppressedLintMessage and Linter.verify
  • Add optional messageId and data properties to suggestion types

Closes #19119

Is there anything you'd like reviewers to focus on?

No

@DMartens
DMartens requested a review from a team as a code owner November 12, 2024 11:48
@eslint-github-bot eslint-github-bot Bot added the documentation Relates to ESLint's documentation label Nov 12, 2024
@netlify

netlify Bot commented Nov 12, 2024 •

Copy link
Copy Markdown

✅ Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit e1ef51e
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6733ce71d222a20008b04ee8
😎 Deploy Preview https://deploy-preview-19122--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amareshsm amareshsm added the accepted There is consensus among the team that this change meets the criteria for inclusion label Nov 12, 2024
Comment thread docs/src/integrate/nodejs-api.md Outdated
Comment thread docs/src/integrate/nodejs-api.md Outdated

@fasttime fasttime left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime
fasttime merged commit 895c60f into eslint:main Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Docs: Missing fields in LintMessage type

3 participants