Repository navigation
fix: add missing types for no-misleading-character-class options - #18905
Merged
Merged
Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
amareshsm
approved these changes
Sep 15, 2024
left a comment
•
Member
There was a problem hiding this comment.
LGTM.
no-misleading-character-class option - https://eslint.org/docs/latest/rules/no-misleading-character-class#options
I would like to have this reviewed by the ESLint team before marking it as accepted.
snitin315
approved these changes
Sep 16, 2024
1 task
This was referenced Oct 26, 2024
This was referenced Oct 28, 2024
This was referenced Oct 29, 2024
This was referenced Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Tell us about your environment (
npx eslint --env-info):What parser are you using (place an "X" next to just one item)?
N/A
Please show your full configuration:
N/A
What did you do? Please include the actual source code causing the issue.
Tried to create a custom config using TypeScript as follows:
What did you expect to happen?
Options existing at runtime should be available on the type level.
What actually happened? Please include the actual, raw output from ESLint.
TypeScript flagged a type-level issue as highlighted in the comment above.
What changes did you make? (Give an overview)
Fixed the types to include missing
allowEscapeoption for theno-misleading-character-classrule.Is there anything you'd like reviewers to focus on?
N/A