Skip to content

feat!: default for enforceForClassMembers in no-useless-computed-key - #18054

Merged
mdjermanovic merged 4 commits into
mainfrom
fix-18042
Feb 2, 2024
Merged

feat!: default for enforceForClassMembers in no-useless-computed-key#18054
mdjermanovic merged 4 commits into
mainfrom
fix-18042

Conversation

@fasttime

@fasttime fasttime commented Jan 30, 2024

Copy link
Copy Markdown
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Fixes #18042

What changes did you make? (Give an overview)

This PR changes the default value of the enforceForClassMembers option in the no-useless-computed-key rule to true.

Since this is a breaking change in v9, I've updated the migration guide.

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot Bot added breaking This change is backwards-incompatible feature This change adds a new feature to ESLint labels Jan 30, 2024
@netlify

netlify Bot commented Jan 30, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 50263bb
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65bbd237ac48c50008dec725
😎 Deploy Preview https://deploy-preview-18054--docs-eslint.netlify.app/use/migrate-to-9.0.0
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fasttime fasttime added rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Jan 30, 2024
@fasttime
fasttime marked this pull request as ready for review January 30, 2024 21:01
@fasttime
fasttime requested a review from a team as a code owner January 30, 2024 21:01
@Tanujkanti4441

Tanujkanti4441 commented Jan 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Can you also add To address section in the migration guide to tell the user how previous behavior can be retained?

@Tanujkanti4441

Tanujkanti4441 commented Jan 31, 2024

Copy link
Copy Markdown
Contributor

issue #12048 is also about no-useless-computed-key rule, how about cover it too in this PR, if @mdjermanovic confirms that the behavior of the rule is correct.

@mdjermanovic

mdjermanovic commented Jan 31, 2024

Copy link
Copy Markdown
Member

issue #12048 is also about no-useless-computed-key rule, how about cover it too in this PR, if @mdjermanovic confirms that the behavior of the rule is correct.

I think it should be a separate PR as it isn't related to this option.

mdjermanovic
mdjermanovic reviewed Jan 31, 2024
View reviewed changes
Comment thread docs/src/use/migrate-to-9.0.0.md Outdated
@nzakas

nzakas commented Jan 31, 2024

Copy link
Copy Markdown
Member

Folks: please remember to move PRs through the triage board:
https://eslint.org/docs/latest/maintain/manage-issues#when-an-issue-or-pull-request-is-opened

fasttime and others added 2 commits January 31, 2024 20:50
@fasttime @mdjermanovic
Fix a typo
f74e37a 
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
@fasttime
Add "To address" section
afbb336
@fasttime
fasttime requested a review from mdjermanovic January 31, 2024 20:01
@mdjermanovic

mdjermanovic commented Feb 1, 2024

Copy link
Copy Markdown
Member

There are merge conflicts in the migration guide now.

mdjermanovic
mdjermanovic approved these changes Feb 1, 2024
View reviewed changes

@mdjermanovic mdjermanovic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when merge conflicts are fixed.

@fasttime

fasttime commented Feb 1, 2024

Copy link
Copy Markdown
Member Author

The merge conflicts are fixed.

mdjermanovic
mdjermanovic approved these changes Feb 2, 2024
View reviewed changes

@mdjermanovic mdjermanovic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic
mdjermanovic merged commit 3c4d51d into main Feb 2, 2024
@mdjermanovic
mdjermanovic deleted the fix-18042 branch February 2, 2024 00:24
@baby636 baby636 mentioned this pull request May 21, 2024
Open
@merfu merfu mentioned this pull request May 25, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request May 26, 2024
Open
@lholmquist lholmquist mentioned this pull request May 26, 2024
Closed
@ekmixon ekmixon mentioned this pull request May 26, 2024
Open
@drwho725 drwho725 mentioned this pull request May 28, 2024
Merged
@lholmquist lholmquist mentioned this pull request May 29, 2024
Closed
This was referenced Jun 28, 2024
Closed
Closed
Closed
@hashim21223445 hashim21223445 mentioned this pull request Jul 4, 2024
Merged
This was referenced Jul 4, 2024
Closed
Closed
@snyk-io snyk-io Bot mentioned this pull request Jul 5, 2024
Closed
@hashim21223445 hashim21223445 mentioned this pull request Jul 6, 2024
Merged
@snyk-io snyk-io Bot mentioned this pull request Jul 6, 2024
Closed
@lholmquist lholmquist mentioned this pull request Jul 6, 2024
Closed
@saidsef saidsef mentioned this pull request Jul 6, 2024
Closed
@junsulee junsulee mentioned this pull request Jul 6, 2024
Open
@ekmixon ekmixon mentioned this pull request Jul 6, 2024
Open
@snyk-io snyk-io Bot mentioned this pull request Jul 7, 2024
Merged
This was referenced Jul 9, 2024
Closed
Closed
@jadsongmatos jadsongmatos mentioned this pull request Jul 10, 2024
Merged
@lholmquist lholmquist mentioned this pull request Jul 11, 2024
Closed
This was referenced Jul 12, 2024
Merged
Merged
This was referenced Jul 12, 2024
Closed
Closed
@lholmquist lholmquist mentioned this pull request Jul 13, 2024
Closed
@saidsef saidsef mentioned this pull request Jul 13, 2024
Closed
@hashim21223445 hashim21223445 mentioned this pull request Jul 14, 2024
Closed
@saidsef saidsef mentioned this pull request Jul 15, 2024
Closed
This was referenced Jul 16, 2024
Closed
Closed
@eslint-github-bot eslint-github-bot Bot locked and limited conversation to collaborators Aug 1, 2024
@eslint-github-bot eslint-github-bot Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees

No one assigned

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible feature This change adds a new feature to ESLint rule Relates to ESLint's core rules

Projects

Triage
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rule Change: Change default for no-useless-computed-key's enforceForClassMembers option to true

4 participants

@fasttime @Tanujkanti4441 @mdjermanovic @nzakas