Skip to content

feat: show warning on unrecognized idp group and role mapping claims - #16485

Merged
aslilac merged 25 commits into
mainfrom
lilac/group-role-sync-missing-given-warning
Feb 7, 2025
Merged

aslilac merged 25 commits into
mainfrom
lilac/group-role-sync-missing-given-warning

Conversation

@aslilac

@aslilac aslilac commented Feb 6, 2025 •

Copy link
Copy Markdown
Member

Closes coder/internal#82

Screenshot 2025-02-06 at 6 11 12 PM

Same warning as we added for org sync, now for group and role sync as well

@aslilac
aslilac changed the base branch from main to lilac/idp-sync-missing-given-warning February 6, 2025 22:20
Base automatically changed from lilac/idp-sync-missing-given-warning to main February 6, 2025 23:45
@aslilac
aslilac requested a review from jaaydenh February 7, 2025 01:09
@aslilac
aslilac marked this pull request as ready for review February 7, 2025 01:12

@jaaydenh jaaydenh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aslilac
aslilac merged commit 323559b into main Feb 7, 2025
@aslilac
aslilac deleted the lilac/group-role-sync-missing-given-warning branch February 7, 2025 18:41
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

site: display warning when the chosen IDP role, group or org in the table does not match an existing claim field value

2 participants