feat: add combobox for selecting claim field value for group/role idp sync - #16459
Merged
Merged
Conversation
jaaydenh
changed the title
jaaydenh
changed the title
jaaydenh
changed the title
aslilac
reviewed
Feb 6, 2025
aslilac
left a comment
aslilac
left a comment
Member
There was a problem hiding this comment.
main thing I would like changed is the use of onSuccess. we're gonna have to get rid of all those one day, I'd rather not make the list longer. 😅
otherwise looks good!
jaaydenh
force-pushed
the
jaaydenh/groups-roles-autocomplete
branch
from
February 7, 2025 20:37
97f619d to
447cad7
Compare
aslilac
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contributes to coder/internal#330
This is a followup to #16335
This adds a combobox that swaps with the input for the idp group and idp role names when the sync field returns claim values from the claim field values endpoint. If no claim field values are returned then the input remains instead of the combobox.