Skip to content
This repository was archived by the owner on Aug 11, 2026. It is now read-only.

fix: automatically detect arm64 - #125

Merged
joseph-sentry merged 1 commit into
mainfrom
joseph/arch
May 14, 2025
Merged

fix: automatically detect arm64#125
joseph-sentry merged 1 commit into
mainfrom
joseph/arch

Conversation

@joseph-sentry

@joseph-sentry joseph-sentry commented May 8, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented May 8, 2025 •
edited
Loading

Copy link
Copy Markdown

❌ 11 Tests Failed:

Tests completed Failed Passed Skipped
16 11 5 0
View the top 3 failed test(s) by shortest run time 
 fully covered
Stack Traces | 0s run time 
Error: expect(received).toEqual(expected) // deep equality

Expected: false
Received: true
    at Object.<anonymous> (.../demo/coverage-test/coverage.test.ts:10:39)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
 fully covered
Stack Traces | 0s run time 
Error: expect(received).toEqual(expected) // deep equality

Expected: false
Received: true
    at Object.<anonymous> (.../demo/coverage-test/coverage.test.ts:10:39)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
 fully covered
Stack Traces | 0s run time 
Error: expect(received).toEqual(expected) // deep equality

Expected: false
Received: true
    at Object.<anonymous> (.../demo/coverage-test/coverage.test.ts:10:39)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@codecov-staging

codecov-staging Bot commented May 8, 2025 •
edited
Loading

Copy link
Copy Markdown

❌ 13 Tests Failed:

Tests completed Failed Passed Skipped
16 13 3 0
View the top 3 failed test(s) by shortest run time 
 subtracts 2 - 3 to equal -1
Stack Traces | 0s run time 
Error: expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: -1
    at Object.<anonymous> (.../demo/calculator/calculator.test.ts:10:31)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
 subtracts 2 - 3 to equal -1
Stack Traces | 0s run time 
Error: expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: -1
    at Object.<anonymous> (.../demo/calculator/calculator.test.ts:10:31)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
 subtracts 2 - 3 to equal -1
Stack Traces | 0s run time 
Error: expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: -1
    at Object.<anonymous> (.../demo/calculator/calculator.test.ts:10:31)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@webknjaz webknjaz mentioned this pull request May 9, 2025
Closed
webknjaz
webknjaz reviewed May 9, 2025
View reviewed changes

@webknjaz webknjaz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Could you add ubuntu-24.04-arm to https://github.com/codecov/test-results-action/blob/f2dba72/.github/workflows/main.yml#L13C13-L13C58, though? It'd be a good smoke test to have it there for the purposes dogfooding...

@joseph-sentry
joseph-sentry force-pushed the joseph/arch branch 2 times, most recently from 3c32df2 to 23bf486 Compare May 9, 2025 14:04
@joseph-sentry
joseph-sentry merged commit 983465b into main May 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@webknjaz webknjaz webknjaz left review comments
@thomasrockhu-codecov thomasrockhu-codecov thomasrockhu-codecov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joseph-sentry @webknjaz @thomasrockhu-codecov