Repository navigation
Fix use of safe.directory inside containers - #1768
Conversation
Inside a container the actual workspace path is a mount point and not the same as outside the container.
E.g.:
- `${{github.workspace}} == /home/runner/work/locale/locale`
- `$GITHUB_WORKSPACE == /__w/locale/locale`
So it seems `/home/runner/work` is mounted at `/__w` and this is reflected by the environment variable but not the context.
So use that variable instead.
|
@thomasrockhu-codecov Your change breaks this: |
|
@Flamefire can you link a PR with |
|
I had a test at #1767 (comment) Scroll to "Debug coverage" and see the output:
This is from https://github.com/boostorg/locale/blob/456e6e7be28c5e82b99b767ab2e48bebf470a8c0/.github/workflows/ci.yml#L371 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1768 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. |
|
Thank you for merging this! Is there any estimate for the next release? Then I'd rerun my job(s) using the action |
|
@Flamefire some time this week, likely today or tomorrow |
Inside a container the actual workspace path is a mount point and not the same as outside the container. E.g.:
${{github.workspace}} == /home/runner/work/locale/locale$GITHUB_WORKSPACE == /__w/locale/localeSo it seems
/home/runner/workis mounted at/__wand this is reflected by the environment variable but not the context. So use that variable instead.Fixes #1767