Skip to content

fix: override commit and pr values for PR cases - #1657

Merged
thomasrockhu-codecov merged 9 commits into
mainfrom
th/fix-pr-and-commit-fixes
Nov 15, 2024
Merged

thomasrockhu-codecov merged 9 commits into
mainfrom
th/fix-pr-and-commit-fixes

Conversation

@thomasrockhu-codecov

@thomasrockhu-codecov thomasrockhu-codecov commented Nov 15, 2024 •

Copy link
Copy Markdown
Contributor

@thomasrockhu-codecov
thomasrockhu-codecov merged commit 5c47607 into main Nov 15, 2024
@thomasrockhu-codecov
thomasrockhu-codecov deleted the th/fix-pr-and-commit-fixes branch November 15, 2024 15:27
@vtjnash

vtjnash commented Nov 18, 2024

Copy link
Copy Markdown

If I understand this PR correctly, it is now causing "Fork detected, tokenless uploading used" to be printed (harmlessly?) on many uploads, when following the documentation to pass the value as CODECOV_TOKEN, since this renamed it to CC_TOKEN. For example: https://github.com/vtjnash/Glob.jl/actions/runs/11898703761/job/33155756934

@thomasrockhu-codecov

Copy link
Copy Markdown
Contributor Author

@vtjnash 5.0.3 should fix the issue, but if it does not, please open one in this repo and tag @codecov/report-upload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants