Skip to content

fix(service): show paths in plugin loading errors - #11921

Merged
ematipico merged 1 commit into
biomejs:mainfrom
hirehamir:fix/plugin-error-paths
Sep 24, 2026
Merged

fix(service): show paths in plugin loading errors#11921
ematipico merged 1 commit into
biomejs:mainfrom
hirehamir:fix/plugin-error-paths

Conversation

@hirehamir

@hirehamir hirehamir commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #10846

Test Plan

crates/biome_cli/tests/snapshots/main_commands_lint/missing_plugins_report_their_paths.snap

shows the new behavior.

Without this change

Users get less friendly and less readable error messages, like

npx biome format
plugin ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ✖ Error(s) during loading of plugins:
    Cannot read file.Cannot read file.

With this change

Users get friendlier and more readable error messages, like

plugin ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
  × Error(s) during loading of plugins:
    missingOne.grit: Cannot read file.
    missingTwo.grit: Cannot read file.

@agentscanapp

agentscanapp Bot commented Sep 23, 2026

Copy link
Copy Markdown

A maintainer will take a look as soon as they can. In the meantime, please make sure that:

  • the description follows our PR template
  • any related issues are linked
  • existing tests still pass

@changeset-bot

changeset-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 762bb5c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-win32-x64 Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/wasm-web Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added A-CLI Area: CLI A-Project Area: project labels Sep 23, 2026
@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: biomejs/biome/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 0b70d765-a7b3-4507-8ff1-9ea04971679d

📥 Commits

Reviewing files that changed from the base of the PR and between 3260602 and 762bb5c.

⛔ Files ignored due to path filters (1)
  • crates/biome_cli/tests/snapshots/main_commands_lint/missing_plugins_report_their_paths.snap is excluded by !**/*.snap and included by **
📒 Files selected for processing (3)
  • .changeset/fix-plugin-load-error-paths.md
  • crates/biome_cli/tests/commands/lint.rs
  • crates/biome_service/src/diagnostics.rs

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

Plugin-load diagnostics now show each error on a separate line and include the file path when the diagnostic refers to a file. A new CLI test checks the output for two missing plugins. A patch changeset records the change.

Suggested reviewers: ematipico

Priority: ⬇️ Low

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 762bb

Missing-plugin errors identify the affected files, and no actionable merge risk is established.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: showing plugin paths in loading errors. It is concise and specific.
Description check ✅ Passed The description explains the issue, the change, and the test evidence. It is directly related to the changeset.
Linked Issues check ✅ Passed The implementation meets #10846. PluginErrors::message now prefixes file-based diagnostic errors with the plugin path and renders each error on its own line. The new `missing_plugins_report_their_pa…
Out of Scope Changes check ✅ Passed The changeset, diagnostic update, and focused lint test all support the linked objective in #10846. No unrelated changes are shown in the pull request summary.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@codspeed

codspeed Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 9 untouched benchmarks
⏩ 351 skipped benchmarks1

Comparing hirehamir:fix/plugin-error-paths (762bb5c) with main (3260602)

Open in CodSpeed

Footnotes

  1. 351 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@ematipico
ematipico merged commit d568632 into biomejs:main Sep 24, 2026
32 checks passed
@github-actions github-actions Bot mentioned this pull request Sep 24, 2026
Merged
@hirehamir
hirehamir deleted the fix/plugin-error-paths branch September 25, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

No one assigned

Labels

A-CLI Area: CLI A-Project Area: project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

📎 Add details to plugin file not found

2 participants

@hirehamir @ematipico