feat(linter): add noReactObjectTypeAsDefaultProp rule - #10634

.changeset/add-no-object-type-as-default-prop.md (1)

5-5: ⚡ Quick win

Add a tiny invalid example.

As per coding guidelines, new lint-rule changesets should show an invalid case, not just prose. A single inline example would make this easier to scan.

💡 Suggested tweak

-Added [`noObjectTypeAsDefaultProp`](https://biomejs.dev/linter/rules/no-object-type-as-default-prop/) to the nursery group. This rule disallows reference-type values (arrays, objects, functions, classes, `new` expressions, JSX elements, regular expressions, and `Symbol()`) as default values for destructured props in React function components, because a new instance is created on every render, which can break memoization and cause unnecessary re-renders. It ports [`no-object-type-as-default-prop`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-object-type-as-default-prop.md) from `eslint-plugin-react`.
+Added [`noObjectTypeAsDefaultProp`](https://biomejs.dev/linter/rules/no-object-type-as-default-prop/) to the nursery group. For example, `function Foo({ bar = {} }) {}` is now flagged. This rule disallows reference-type values (arrays, objects, functions, classes, `new` expressions, JSX elements, regular expressions, and `Symbol()`) as default values for destructured props in React function components, because a new instance is created on every render, which can break memoization and cause unnecessary re-renders. It ports [`no-object-type-as-default-prop`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-object-type-as-default-prop.md) from `eslint-plugin-react`.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.changeset/add-no-object-type-as-default-prop.md at line 5, The changeset
file for the noObjectTypeAsDefaultProp rule lacks an invalid code example, which
is required per coding guidelines for lint-rule changesets. Add a single inline
code example after the prose description that demonstrates invalid usage of the
rule, such as a React function component with a destructured prop that has a
reference-type default value (like an object literal, array, or function). This
will make the changeset easier to scan and understand what the rule disallows.

Source: Coding guidelines

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

crates/biome_js_analyze/src/lint/nursery/no_react_object_type_as_default_prop.rs (1)

213-235: ⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Early return discards violations and skips remaining properties.

Lines 214 and 225 use .ok()? inside the for loop, causing the entire function to return None when any property or initialiser expression fails to parse. This discards any violations already collected in defaults and prevents checking the remaining properties.

Replace .ok()? with let Ok(...) else { continue } to skip malformed entries whilst continuing to accumulate violations.

🔧 Proposed fix

 let mut defaults = Vec::new();
 for property in object_pattern.properties() {
-    let property = property.ok()?;
+    let Ok(property) = property else {
+        continue;
+    };

     let AnyJsObjectBindingPatternMember::JsObjectBindingPatternShorthandProperty(shorthand) =
         property
     else {
         continue;
     };

     let Some(initializer) = shorthand.init() else {
         continue;
     };
-    let default_value = initializer.expression().ok()?;
+    let Ok(default_value) = initializer.expression() else {
+        continue;
+    };

     let Some(kind) = forbidden_default_kind(&default_value) else {
         continue;
     };

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@crates/biome_js_analyze/src/lint/nursery/no_react_object_type_as_default_prop.rs`
around lines 213 - 235, In the for loop that iterates through
object_pattern.properties(), replace the two `.ok()?` calls with the `let
Ok(...) else { continue }` pattern. Specifically, change the line that assigns
property from property.ok()? to use let Ok(property) = property else { continue
}, and change the line that assigns default_value from
initializer.expression().ok()? to use let Ok(default_value) =
initializer.expression() else { continue }. This prevents early function return
on parse errors and allows the loop to continue accumulating violations in the
defaults vector while skipping malformed entries.