Skip to content

Remove unused functions from renamer.js. - #5965

Merged
hzoo merged 1 commit into
babel:masterfrom
mcav:patch-1
Jul 20, 2017
Merged

hzoo merged 1 commit into
babel:masterfrom
mcav:patch-1

Conversation

@mcav

@mcav mcav commented Jul 18, 2017

Copy link
Copy Markdown
Contributor

Firefox emits warnings about unreachable code after return statements. This patch removes those unused functions entirely (as suggested in #5962) to silence these errors.

Q A
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
Spec Compliancy? n/a
Tests Added/Pass? n/a
Fixed Tickets
License MIT
Doc PR
Dependency Changes

@xtuc xtuc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 馃憤

@xtuc xtuc added PR: Internal 馃彔 A type of pull request used for our changelog categories PR: Polish 馃拝 A type of pull request used for our changelog categories labels Jul 20, 2017
@hzoo
hzoo merged commit fe13ba8 into babel:master Jul 20, 2017
@hzoo hzoo removed the PR: Polish 馃拝 A type of pull request used for our changelog categories label Jul 20, 2017
@hzoo

hzoo commented Jul 20, 2017

Copy link
Copy Markdown
Member

Cool thanks 馃槃

@lock lock Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 馃彔 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants