Skip to content

Hoist toSequenceExpression's convert helper - #5693

Merged
hzoo merged 4 commits into
babel:masterfrom
jridgewell:hoist-toSequenceExpression
May 19, 2017
Merged

Hoist toSequenceExpression's convert helper#5693
hzoo merged 4 commits into
babel:masterfrom
jridgewell:hoist-toSequenceExpression

Conversation

@jridgewell

@jridgewell jridgewell commented May 3, 2017 •
edited
Loading

Copy link
Copy Markdown
Member
Q A
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No?
Deprecations? No
Spec Compliancy? No
Tests Added/Pass? Lots
Fixed Tickets Fixes #5080, Fixes #4224
License MIT
Doc PR
Dependency Changes

Like it says. Also fixes two bugs when recursing into IfStatements or BlockStatements that themselves bail.

@mention-bot

mention-bot commented May 3, 2017

Copy link
Copy Markdown

@jridgewell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @boopathi and @zertosh to be potential reviewers.

@codecov

codecov Bot commented May 3, 2017

Copy link
Copy Markdown

Codecov Report

Merging #5693 into master will increase coverage by 0.07%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5693      +/-   ##
=========================================
+ Coverage   84.72%   84.8%   +0.07%     
=========================================
  Files         204     204              
  Lines        9600    9603       +3     
  Branches     2697    2700       +3     
=========================================
+ Hits         8134    8144      +10     
+ Misses        978     975       -3     
+ Partials      488     484       -4
Impacted Files Coverage Δ
packages/babel-types/src/converters.js 94.55% <97.43%> (+3.58%) ⬆️
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.59% <0%> (+0.42%) ⬆️
packages/babel-traverse/src/path/context.js 87.06% <0%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 412180e...8aee10c. Read the comment docs.

@codecov

codecov Bot commented May 3, 2017 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #5693 into master will increase coverage by 0.04%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5693      +/-   ##
==========================================
+ Coverage   84.72%   84.77%   +0.04%     
==========================================
  Files         204      204              
  Lines        9600     9603       +3     
  Branches     2697     2700       +3     
==========================================
+ Hits         8134     8141       +7     
  Misses        978      978              
+ Partials      488      484       -4
Impacted Files Coverage Δ
packages/babel-types/src/converters.js 94.55% <97.43%> (+3.58%) ⬆️
packages/babel-traverse/src/path/context.js 85.34% <0%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 412180e...f265860. Read the comment docs.

@jridgewell
jridgewell force-pushed the hoist-toSequenceExpression branch from 8aee10c to f265860 Compare May 3, 2017 05:55
@hzoo hzoo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label May 19, 2017
@hzoo
hzoo merged commit 5f866f2 into babel:master May 19, 2017
This was referenced May 19, 2017
Closed
Closed
@hzoo

hzoo commented May 19, 2017

Copy link
Copy Markdown
Member

Oh dang this was on master haha..

@jridgewell

jridgewell commented May 19, 2017

Copy link
Copy Markdown
Member Author

Whoops, I'll port it over.

@jridgewell
jridgewell deleted the hoist-toSequenceExpression branch May 19, 2017 21:12
jridgewell added a commit to jridgewell/babel that referenced this pull request May 19, 2017
@jridgewell
Hoist toSequenceExpression's convert helper (babel#5693)
58216f5
@jridgewell jridgewell mentioned this pull request May 19, 2017
Merged
jridgewell added a commit that referenced this pull request May 20, 2017
@jridgewell
Merge pull request #5753 from jridgewell/7.0
943fa8a 
Hoist toSequenceExpression's convert helper (#5693)
This was referenced Mar 14, 2018
Closed
Closed
Closed
Merged
Merged
Closed
Closed
This was referenced Mar 16, 2018
Closed
Closed
Closed
Merged
Merged
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request Aug 30, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Sep 19, 2019
Open
@lock lock Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

area: perf outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Declarations and ThrowStatement in an IfStatement within DoExpression breaks compilation If/else block fails inside do expression (T7267)

3 participants

@jridgewell @mention-bot @hzoo