Repository navigation
Analyze ClassAccessorProperty to prevent the no-undef rule - #16884
Merged
Merged
Conversation
a.js:
```js
class A {
accessor b;
}
```
Current and expected behavior:
```bash
npx eslint a.js
```
```
a.js
2:11 error 'b' is not defined no-undef
✖ 1 problem (1 error, 0 warnings)
```
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58079 |
Contributor
|
Can you add some new tests to babel/eslint/babel-eslint-tests/test/integration/eslint/verify.js Lines 1761 to 1794 in 959a51a |
JLHwung
approved these changes
Oct 6, 2024
| ); | ||
| }); | ||
|
|
||
| it("no-use-before-define allows referencing the class in a accessor", () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| it("no-use-before-define allows referencing the class in a accessor", () => { | |
| it("no-use-before-define allows referencing the class in an accessor", () => { |
JLHwung
added
PR: Bug Fix 🐛
github-actions
Bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a.js:
Current and expected behavior: