Skip to content

docs(readme): fix broken interceptor test link - #11119

Merged
jasonsaayman merged 3 commits into
axios:v1.xfrom
gi9439041-png:fix/readme-interceptor-test-link
Aug 4, 2026
Merged

jasonsaayman merged 3 commits into
axios:v1.xfrom
gi9439041-png:fix/readme-interceptor-test-link

Conversation

@gi9439041-png

@gi9439041-png gi9439041-png commented Aug 2, 2026 •

Copy link
Copy Markdown
Contributor

🏄

Summary

The README's "Multiple interceptors" section links to ./test/specs/interceptors.spec.js, which no longer exists — the test suite was reorganized into tests/unit, tests/browser, and tests/smoke. This PR updates the link to point to tests/browser/interceptors.browser.test.js, which covers the multiple-interceptor ordering and chaining behavior described in that section (see the given multiple response interceptors block).

Test plan

  • Verified test/specs/interceptors.spec.js does not exist in the current tree
  • Verified tests/browser/interceptors.browser.test.js exists and contains tests matching the README's description (execution order, chained results, fulfillment/rejection handling)
  • Docs-only change, no code affected

Summary by cubic

Fix broken README link to interceptor tests by pointing to ./tests/browser/interceptors.browser.test.js after the test suite reorg. This ensures the “Multiple interceptors” section links to the correct examples.

Docs

  • Update link from ./test/specs/interceptors.spec.js to ./tests/browser/interceptors.browser.test.js.
  • Reason: old path was removed; new file covers ordering and chaining.
  • Update any references in /docs/ that still use the old path.

Impact

  • Testing: docs-only; no tests added. Verified old file is gone and new file includes relevant cases.
  • Semantic version impact: none (no runtime changes).

Written for commit 02af6df. Summary will update on new commits.

Review in cubic

The path ./test/specs/interceptors.spec.js no longer exists after the
test suite was reorganized into tests/unit, tests/browser, and
tests/smoke. Point to tests/browser/interceptors.browser.test.js,
which covers the multiple-interceptor ordering and chaining behavior
described in this section.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Aug 2, 2026 •

Copy link
Copy Markdown

Greptile Summary

Updates the README’s “Multiple interceptors” link to the current browser interceptor test file. The previous README target did not exist, while the updated target resolves successfully and contains the documented response-interceptor ordering, chaining, returned-value, rejection, and recovery coverage.

Confidence Score: 5/5

Safe to merge: no blocking failure remains.

The README link was exercised against both the prior and updated revisions. The old path was absent; the replacement path exists and contains the relevant multiple response interceptor coverage.

T-Rex T-Rex Logs

What T-Rex did

  • The Axios docs(readme): fix broken interceptor test link #11119 Markdown-link checker was run against the old target and exited with code 1, proving the old target was absent.
  • The same checker was run against the replacement target and exited with code 0, confirming the new target exists and includes multiple response interceptor coverage at tests/browser/interceptors.browser.test.js:606.
  • The Axios docs(readme): fix broken interceptor test link #11119 Markdown-link checker script and its before/after outputs were uploaded for review.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (3): Last reviewed commit: "Merge branch 'v1.x' into fix/readme-inte..." | Re-trigger Greptile

@jasonsaayman jasonsaayman added the commit::docs The PR is related to docs label Aug 4, 2026
@jasonsaayman
jasonsaayman merged commit ceb4176 into axios:v1.x Aug 4, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit::docs The PR is related to docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants