Repository navigation
fix(glue-alpha): correct OutputFormat.AVRO/ORC type and tidy GA-hygiene items - #38593
Merged
Merged
Conversation
…ne items `OutputFormat.AVRO` and `OutputFormat.ORC` were constructed as `InputFormat` instances — they compiled only because the two classes are structurally identical. They are now `OutputFormat` instances; the emitted Hadoop class-name strings are unchanged, so synthesized output is identical. Also: - `renderColumns` typed as the malformed `Array<Column | Column>` -> `Column[]` in both `S3Table` and `ExternalTable`. - `Database.locationUri` is now `readonly` (it is assigned only at construction). Addresses the OutputFormat, malformed-column-array, and mutable-`locationUri` findings from the aws-glue-alpha pre-GA API review.
otaviomacedo
temporarily deployed
to
automation
August 18, 2026 08:59 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
automation
August 18, 2026 08:59 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
automation
August 18, 2026 08:59 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
PRs without a linked issue will receive lower priority for review and merging. Please update the description to follow the PR template and include a line like |
otaviomacedo
added
the
pr-linter/exempt-integ-test
otaviomacedo
temporarily deployed
to
automation
August 18, 2026 09:01 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
automation
August 18, 2026 09:01 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
aws-cdk-automation
previously requested changes
Aug 18, 2026
…nces Regression test for the type correction: these members were previously `InputFormat` instances, which compiled in TypeScript (structural typing) but was unusable in jsii's nominal languages where an `OutputFormat` is required. `instanceof` distinguishes the two at runtime, so this fails on the pre-fix code.
otaviomacedo
temporarily deployed
to
automation
August 18, 2026 09:40 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
automation
August 18, 2026 09:40 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
aws-cdk-automation
dismissed
their stale review
August 18, 2026 09:42
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
otaviomacedo
temporarily deployed
to
automation
August 18, 2026 09:48 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
aws-cdk-automation
added
the
pr/needs-maintainer-review
aws-cdk-automation
temporarily deployed
to
automation
August 18, 2026 10:40 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
August 18, 2026 10:41 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
alvazjor
approved these changes
Aug 18, 2026
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
Merge Queue Status
This pull request spent 38 minutes 4 seconds in the queue, including 37 minutes 21 seconds running CI. Required conditions to merge
|
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
aws-cdk-automation
temporarily deployed
to
automation
August 18, 2026 13:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OutputFormat.AVROandOutputFormat.ORCwere constructed asInputFormatinstances — they compiled only because the two classes are structurally identical. They are nowOutputFormatinstances; the emitted Hadoop class-name strings are unchanged, so synthesized output is identical.Also:
renderColumnstyped as the malformedArray<Column | Column>->Column[]in bothS3TableandExternalTable.Database.locationUriis nowreadonly(it is assigned only at construction).BREAKING CHANGE: this is a corrective breaking change. Apps that leaned on the bug, and did things like
InputFormat x = OutputFormat.AVRO;will get a compilation error in other jsii languages. The intended usage, on the other hand, was broken before and works now.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license